Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: have run_compiler bubble up compilation results #8009

Closed
wants to merge 1 commit into from
Closed

rustc: have run_compiler bubble up compilation results #8009

wants to merge 1 commit into from

Conversation

emberian
Copy link
Member

No description provided.

@graydon
Copy link
Contributor

graydon commented Jul 23, 2013

why?

@emberian
Copy link
Member Author

run_compiler is the simplest interface to rustc as a library, but actually using it is impossible unless you just want its side-effects. not using it means you need to build the configuration and parse arguments yourself (for the case where you want to have the same arguments as rustc). I need this for rustdoc_ng; if there's another simple way to accomplish this, I must have missed it.

@graydon
Copy link
Contributor

graydon commented Jul 23, 2013

oh. I didn't land the patch here I meant to. improves the interface substantially. lemme dig it up, 1 sec.

@graydon
Copy link
Contributor

graydon commented Jul 27, 2013

sorry I'm late getting back to this: #8077 is the branch I had in mind. If you like it (and I suggest possibly running it by a couple other core devs), land it and close this one. It's how I'd prefer to handle the clunkiness of compile_upto.

@graydon
Copy link
Contributor

graydon commented Jul 28, 2013

If #8077 was satisfactory, can we close this?

@emberian
Copy link
Member Author

Yep.

@emberian emberian closed this Jul 28, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Nov 23, 2021
…t, r=giraffate

Allow `suboptimal_flops` in const functions

This PR allows `clippy::suboptimal_flops` in constant functions. The check also effects the `clippy::imprecise_flops` lint logic. However, this doesn't have any effects as all functions checked for are not const and can therefore not be found in such functions.

---

changelog: [`suboptimal_flops`]: No longer triggers in constant functions

Closes: rust-lang/rust-clippy#8004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants