s/"\.to_string\(/"\.to_owned\(

[oli-obk]

don't go through formatting code to convert a str lit to a String

related: #19708

[rust-highfive]

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

[alexcrichton]

Are there performance numbers for this change? This is not the idiomatic way of converting to a String, and it's a massive change to take without having some concrete motivation (e.g. numbers).

[steveklabnik]

Yes, I've always been using to_string(), even though it's slower, because it's more semantically accurate. And it may get to be equally fast in the future, which would then make us switch this back, or at least, I'd hope so.

to_owned() is great for generic code, but outside of generics, to_string() is better.

[oli-obk]

makes sense :) my motivation was far fetched anyway