Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate vecmap #26734

Merged
merged 1 commit into from
Jul 30, 2015
Merged

deprecate vecmap #26734

merged 1 commit into from
Jul 30, 2015

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Jul 2, 2015

VecMap doesn't really fit with the current standard library's strategy (small!).

I've mirrored the code to https://github.com/contain-rs/vec-map

but @GBGamer has already claimed the name on crates.io a couple months ago for the same purpose. It hasn't been updated since, though.

CC @rust-lang/libs

@rust-highfive
Copy link
Collaborator

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@sfackler
Copy link
Member

sfackler commented Jul 2, 2015

👍

1 similar comment
@BurntSushi
Copy link
Member

👍

@alexcrichton
Copy link
Member

Sounds good to me, but the ownership of the crate on crates.io should probably fall under the contain-rs organization. @GBGamer would you be ok transferring ownership? Otherwise a vecmap crate may not be so bad.

@aturon
Copy link
Member

aturon commented Jul 6, 2015

I'm fine with this as well.

@Gankra
Copy link
Contributor Author

Gankra commented Jul 9, 2015

I hacked into crates.io and reverse engineered the .crate format to take control of the vec_map namespace via carefully crafted TCP/IP packets.

0.1.0 published.

@Gankra Gankra added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jul 9, 2015
@alexcrichton
Copy link
Member

@bors: r+ 98b95a5c141fc3ae78bda7d687fc087f33cbc54b

Not sure how this flew under the radar for so long :(

@bors
Copy link
Contributor

bors commented Jul 29, 2015

⌛ Testing commit 98b95a5 with merge 137d6ca...

@bors
Copy link
Contributor

bors commented Jul 29, 2015

💔 Test failed - auto-mac-64-opt

@Gankra
Copy link
Contributor Author

Gankra commented Jul 29, 2015

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jul 29, 2015

📌 Commit 841b1e6 has been approved by alexcrichton

@Gankra
Copy link
Contributor Author

Gankra commented Jul 29, 2015

@bors r-

@Gankra
Copy link
Contributor Author

Gankra commented Jul 29, 2015

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jul 29, 2015

📌 Commit 2907611 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 30, 2015

⌛ Testing commit 2907611 with merge 56fd71b...

@bors
Copy link
Contributor

bors commented Jul 30, 2015

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Jul 29, 2015 at 5:56 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/5896


Reply to this email directly or view it on GitHub
#26734 (comment).

@bors
Copy link
Contributor

bors commented Jul 30, 2015

⌛ Testing commit 2907611 with merge 0bc993c...

bors added a commit that referenced this pull request Jul 30, 2015
VecMap doesn't really fit with the current standard library's strategy (small!).

I've mirrored the code to https://github.com/contain-rs/vec-map

but @GBGamer has already claimed the name on crates.io a couple months ago for the same purpose. It hasn't been updated since, though.

CC @rust-lang/libs
@bors bors merged commit 2907611 into rust-lang:master Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants