Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better object defaults warn beta #26829

Merged
merged 7 commits into from Jul 8, 2015
Merged

Better object defaults warn beta #26829

merged 7 commits into from Jul 8, 2015

Conversation

nikomatsakis
Copy link
Contributor

Rebase of PR #26370

r? @alexcrichton

@nikomatsakis
Code up the new lifetime default rules, but leave them disabled
2be6107 
for now.
@nikomatsakis
Add a boolean flag to ExistentialBounds tracking whether the
840e774 
region-bound is expected to change in Rust 1.3, but don't use it for
anything in this commit. Note that this is not a "significant" part of
the type (it's not part of the formal model) so we have to normalize
this away or trans starts to get confused because two equal types wind
up with distinct LLVM types.
@nikomatsakis
After inferring regions, scan for any bounds that are due to a lifetime
8c662eb 
bound that is likely to change. In that case, it will change to 'static,
so then scan down the graph to see whether there are any hard
constraints that would prevent 'static from being a valid value
here. Report a warning.
@nikomatsakis
Adjust tests to silence warnings (or record them, as appropriate).
9cdaa1f
@nikomatsakis
Now that I made the warning smarter, these tests no longer require mo…
db75b07 
…dification
@nikomatsakis
Fix some merge conflicts
973193b
@nikomatsakis
rebase onto beta branch
b229195
@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@nikomatsakis
Copy link
Contributor Author

cc #26438

@nikomatsakis nikomatsakis mentioned this pull request Jul 6, 2015
Closed
@nikomatsakis
Copy link
Contributor Author

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned alexcrichton Jul 8, 2015
@nikomatsakis
Copy link
Contributor Author

oops, just meant to cc, but that's ok

alexcrichton added a commit that referenced this pull request Jul 8, 2015
@alexcrichton
Merge pull request #26829 from nikomatsakis/better-object-defaults-wa…
ebf0c83 
…rn-beta

Better object defaults warn beta
@alexcrichton alexcrichton merged commit ebf0c83 into rust-lang:beta Jul 8, 2015
@bluss bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nikomatsakis @rust-highfive @alexcrichton @brson @bluss