Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better object defaults warn beta #26829

Merged
merged 7 commits into from Jul 8, 2015
Merged

Better object defaults warn beta #26829

merged 7 commits into from Jul 8, 2015

Commits on Jul 6, 2015

  1. Code up the new lifetime default rules, but leave them disabled 

    for now.
    @nikomatsakis
    nikomatsakis committed Jul 6, 2015
    Copy the full SHA
    2be6107 View commit details
    Browse the repository at this point in the history

  2. Add a boolean flag to ExistentialBounds tracking whether the 

    region-bound is expected to change in Rust 1.3, but don't use it for
anything in this commit. Note that this is not a "significant" part of
the type (it's not part of the formal model) so we have to normalize
this away or trans starts to get confused because two equal types wind
up with distinct LLVM types.
    @nikomatsakis
    nikomatsakis committed Jul 6, 2015
    Copy the full SHA
    840e774 View commit details
    Browse the repository at this point in the history

  3. After inferring regions, scan for any bounds that are due to a lifetime 

    bound that is likely to change. In that case, it will change to 'static,
so then scan down the graph to see whether there are any hard
constraints that would prevent 'static from being a valid value
here. Report a warning.
    @nikomatsakis
    nikomatsakis committed Jul 6, 2015
    Copy the full SHA
    8c662eb View commit details
    Browse the repository at this point in the history

  4. Adjust tests to silence warnings (or record them, as appropriate).

    @nikomatsakis
    nikomatsakis committed Jul 6, 2015
    Copy the full SHA
    9cdaa1f View commit details
    Browse the repository at this point in the history

  5. Now that I made the warning smarter, these tests no longer require mo… 

    …dification
    @nikomatsakis
    nikomatsakis committed Jul 6, 2015
    Copy the full SHA
    db75b07 View commit details
    Browse the repository at this point in the history

  6. Fix some merge conflicts

    @nikomatsakis
    nikomatsakis committed Jul 6, 2015
    Copy the full SHA
    973193b View commit details
    Browse the repository at this point in the history

  7. rebase onto beta branch

    @nikomatsakis
    nikomatsakis committed Jul 6, 2015
    Copy the full SHA
    b229195 View commit details
    Browse the repository at this point in the history