Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DefId to be based on a path, and not a NodeId #28742

Merged
merged 17 commits into from
Oct 1, 2015
Merged

Change DefId to be based on a path, and not a NodeId #28742

merged 17 commits into from
Oct 1, 2015

Commits on Oct 1, 2015

  1. move LOCAL_CRATE to cstore

    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    dc4a4ad View commit details
    Browse the repository at this point in the history

  2. add some XXX markers

    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    2dd139f View commit details
    Browse the repository at this point in the history

  3. move job of creating local-def-ids to ast-map (with a few stragglers)

    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    9ff4f57 View commit details
    Browse the repository at this point in the history

  4. change creepy case to call span_bug instead of doing something clearl… 

    …y wrong
    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    aa40a1c View commit details
    Browse the repository at this point in the history

  5. move direct accesses of node to go through as_local_node_id, unless 

    they are being used as an opaque "position identifier"
    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    5600c62 View commit details
    Browse the repository at this point in the history

  6. Rename node_id to var_id and limit to the cases that are actually… 

    … used
    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    1dd5ffa View commit details
    Browse the repository at this point in the history

  7. Remove DefRegion, which is not used

    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    cb784b7 View commit details
    Browse the repository at this point in the history

  8. Move DefLabel out from the def_id() results

    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    95ce1eb View commit details
    Browse the repository at this point in the history

  9. Make calling def_id on a DefSelfTy an error; the previous defids that 

    were returned, either the trait or the *self type itself*, were not
particularly representative of what the Def is (a type parameter).
Rewrite paths to handle this case specially, just as they handle the
primitive case specifically. This entire `def_id` codepath is kind of a
mess.
    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    3b1399d View commit details
    Browse the repository at this point in the history

  10. Introduce semi-duplicate DefIds into DefLocal/DefUpvar to remove use 

    of xxx_local.
    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    a0dc2d9 View commit details
    Browse the repository at this point in the history

  11. build up a set of node-ids that we can construct def-ids from

    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    d7b0eb0 View commit details
    Browse the repository at this point in the history

  12. stop updating parent_node_id when there is no corresponding map entry

    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    34a25db View commit details
    Browse the repository at this point in the history

  13. rename ast_map to hir_map

    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    a6fee06 View commit details
    Browse the repository at this point in the history

  14. Convert DefId to use DefIndex, which is an index into a list of 

    paths, and construct paths for all definitions. Also, stop rewriting
DefIds for closures, and instead just load the closure data from
the original def-id, which may be in another crate.
    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    01f32ac View commit details
    Browse the repository at this point in the history

  15. convert the creepy case to just return None -- in practice, it would 

    have always been returning None anyway, since it was comparing node-ids
across crates incorrectly -- and remove the now unused map
`extern_const_variants`
    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    52a0283 View commit details
    Browse the repository at this point in the history

  16. remove code for re-exports of static methods

    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    6bfdf37 View commit details
    Browse the repository at this point in the history

  17. remove support method for synthetic default method ids

    @nikomatsakis
    nikomatsakis committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    f0dc7bd View commit details
    Browse the repository at this point in the history