Color primitives and aliases in rustdoc #29264
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I think that I like this change better, but I'm going to hold off until after the branch today to do it. Sneaking something like this in right before the release doesn't seem like the right thing to do. |
|
@steveklabnik Any opinion on making all the types a single color instead of varying them? Also, should I add the colored underline on hover? Both are easy to do. |
|
Just examples of how underline on hover looks like:
And:
|
|
@bors: r+ rollup The branch has happened, so let's merge this and see what people think. I expect it landing on nightly will let people give even more/better feedback. |
|
📌 Commit 4cb013e has been approved by |
|
(ie, i think this is a decent solution, but can imagine changing / reverting before 1.6 beta happens) |
|
Ok cool. I'll file an issue to revisit this later then. |
|
Oy, I never pushed the change which made macro links green. Here I fixed it. |
|
@bors: r+ rollup |
|
📌 Commit 11c7bdd has been approved by |
This is an alternative to rust-lang#29240 which fixes rust-lang#15307 by adding colors to primitives and aliases instead of underlining. Try to keep the discussion in rust-lang#29240 for now though so it can be kept track of. A sample rendering is [here](http://mdinger.github.io/rust_std_colored/std/index.html)
This is an alternative to #29240 which fixes #15307 by adding colors to primitives and aliases instead of underlining.
Try to keep the discussion in #29240 for now though so it can be kept track of.
A sample rendering is here