Rollup of 6 pull requests #29444
Merged
Rollup of 6 pull requests #29444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m message I recently discovered that this is not mentioned in the docs, only in the examples, and it's not evident for people coming from C++ r? @steveklabnik
`as_local_node_id`, instead just compare against `Some(id)`. Fixes rust-lang#29161.
Fix corner case in privacy that was causing ICEs when the `source_did` was not crate-local. Full confession: I only kinda sorta understand this code, but afaict it's legit for `source_did` to be from another crate. r? @alexcrichton
This is an alternative to rust-lang#29240 which fixes rust-lang#15307 by adding colors to primitives and aliases instead of underlining. Try to keep the discussion in rust-lang#29240 for now though so it can be kept track of. A sample rendering is [here](http://mdinger.github.io/rust_std_colored/std/index.html)
…m message I recently discovered that this is not mentioned in the docs, only in the examples, and it's not evident for people coming from C++ r? @steveklabnik
…=Manishearth I put the reference under the function return operator `->` rather than near the suggested `!` operators as I thought it was more relevant there. Resolves rust-lang#29431
…xcrichton The raw byte string literal syntax in the syntax index was incorrect. Also added links to the reference for raw and/or byte string literals.
|
@bors: r+ p=1 |
|
📌 Commit 0809eaa has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert!has a second version with a custo… #29417, Add diverging functions-> !to syntax index #29435, Update AUTHORS.txt #29437, Book: Update raw/byte string literal in syntax index #29438