Minor makefile fixes #29820

Merged
merged 3 commits into from Nov 14, 2015

Projects

None yet

4 participants

@wthrowe
Contributor
wthrowe commented Nov 13, 2015

The first commit fixes the "jobserver unavailable" warning reported at gentoo/gentoo-rust#29. I don't think the warning is related to the compilation failure shown there.

The remaining commits are minor fixes I noticed while investigating the jobserver warning.

wthrowe added some commits Nov 13, 2015
@wthrowe wthrowe Escape some variables in llvm.mk
The important one is $(MAKE).  make handles recipes containing the
literal string "$(MAKE)" specially, so it is important to make sure it
isn't evaluated until recipe invocation time.
876c330
@wthrowe wthrowe Clean up some "suspicious" whitespace in target.mk
Emacs warns that makefile lines that start with spaces followed by
tabs are "suspicious".  These were harmless since they were
continuation lines, but getting rid of the warning is nice and this
version looks better.
a0e10b2
@wthrowe wthrowe Remove extra eval call in snap.mk
8d105dd
@brson brson was assigned by rust-highfive Nov 13, 2015
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

Contributor
brson commented Nov 14, 2015

@bors r+ Thanks!

Contributor
bors commented Nov 14, 2015

📌 Commit 8d105dd has been approved by brson

@bors bors added a commit that referenced this pull request Nov 14, 2015
@bors bors Auto merge of #29820 - wthrowe:makefile-fixes, r=brson
The first commit fixes the "jobserver unavailable" warning reported at gentoo/gentoo-rust#29.  I don't think the warning is related to the compilation failure shown there.

The remaining commits are minor fixes I noticed while investigating the jobserver warning.
32202cc
Contributor
bors commented Nov 14, 2015

⌛️ Testing commit 8d105dd with merge 32202cc...

@bors bors merged commit 8d105dd into rust-lang:master Nov 14, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment