Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable the null check elimination pass #30165
Conversation
rust-highfive
assigned
brson
Dec 2, 2015
This comment has been minimized.
This comment has been minimized.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
brson
added
beta-nominated
T-compiler
I-nominated
labels
Dec 2, 2015
This comment has been minimized.
This comment has been minimized.
|
This affects beta too. |
This comment has been minimized.
This comment has been minimized.
|
cc @rust-lang/compiler Edit: I'm just going to do the port. |
brson
added
beta-accepted
and removed
I-nominated
labels
Dec 2, 2015
brson
removed
the
beta-nominated
label
Dec 2, 2015
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 2, 2015
This comment has been minimized.
This comment has been minimized.
bors
merged commit d7ccea6
into
rust-lang:master
Dec 3, 2015
dotdash
deleted the
dotdash:no_null_elim
branch
Jan 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
dotdash commentedDec 2, 2015
This pass causes mis-optimizations in some cases and is probably no
longer really important for us, so let's disable it for now.
Fixes #30081