Tweaks to sections related to Ownership #33095
Conversation
Opening sentence was confusing and something cannot be "one of the most unique" (it either is or is not unique).
…st unique" (it either is or is not unique).
…st unique" (it either is or is not unique).
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
But "distinct" is also a boolean. 😉 Also, distinct is non-evaluative, but e.g. distinguishing is. It's simply "A unique and compelling feature of Rust is its ownership system.". The sentence was I think an attempt at squeezing two ideas (the ownership system is a unique feature + Rust has many nice features) into one sentence. |
|
The issue is that unique is objective. It is a statement of fact. Distinct is subjective. I don't know enough to say that ownership is truly unique. If it is, then say that. Just don't "kinda" say it by saying "most unique". |
|
"guide" was because we used to call them guides 😄 @bors: r+ rollup |
|
📌 Commit f7ec687 has been approved by |
Tweaks to sections related to Ownership
Reading through these sections, I thought the intro text could be improved slightly. So
here is a PR that addresses what was bugging me about it. :-)
Main issue was the wording of the opening sentence ("guide" is not clearly defined and the
wording was a bit too terse in my opinion). I also took issue with the term "one of the most
unique". Uniqueness is a `bool`, not an `f64`. :-)
r? @steveklabnik
Tweaks to sections related to Ownership
Reading through these sections, I thought the intro text could be improved slightly. So
here is a PR that addresses what was bugging me about it. :-)
Main issue was the wording of the opening sentence ("guide" is not clearly defined and the
wording was a bit too terse in my opinion). I also took issue with the term "one of the most
unique". Uniqueness is a `bool`, not an `f64`. :-)
r? @steveklabnik
Reading through these sections, I thought the intro text could be improved slightly. So
here is a PR that addresses what was bugging me about it. :-)
Main issue was the wording of the opening sentence ("guide" is not clearly defined and the
wording was a bit too terse in my opinion). I also took issue with the term "one of the most
unique". Uniqueness is a
bool, not anf64. :-)r? @steveklabnik