Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match check: note "catchall" patterns in unreachable error #33323

Merged
merged 1 commit into from
May 3, 2016

Conversation

birkenfeld
Copy link
Contributor

Caught as catchall patterns are:

  • unconditional name bindings
  • references to them
  • tuple bindings with catchall elements

Fixes #31221.

Caught as catchall patterns are:

* unconditional name bindings
* references to them
* tuple bindings with catchall elements

Fixes rust-lang#31221.
@rust-highfive
Copy link
Collaborator

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 2, 2016

📌 Commit b51698a has been approved by Manishearth

Manishearth added a commit to Manishearth/rust that referenced this pull request May 2, 2016
match check: note "catchall" patterns in unreachable error

Caught as catchall patterns are:

* unconditional name bindings
* references to them
* tuple bindings with catchall elements

Fixes rust-lang#31221.
bors added a commit that referenced this pull request May 2, 2016
Rollup of 14 pull requests

- Successful merges: #32756, #33129, #33225, #33260, #33309, #33320, #33323, #33324, #33325, #33330, #33332, #33334, #33335, #33346
- Failed merges:
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2016
match check: note "catchall" patterns in unreachable error

Caught as catchall patterns are:

* unconditional name bindings
* references to them
* tuple bindings with catchall elements

Fixes rust-lang#31221.
bors added a commit that referenced this pull request May 3, 2016
Rollup of 14 pull requests

- Successful merges: #32756, #33129, #33225, #33260, #33309, #33320, #33323, #33324, #33325, #33330, #33332, #33334, #33335, #33346
- Failed merges:
@bors bors merged commit b51698a into rust-lang:master May 3, 2016
@birkenfeld birkenfeld deleted the issue-31221 branch May 3, 2016 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants