borrowck: clearer error message for mutability violation #33347
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the X in "cannot assign to X" can be quite involved, it is easy for the user to assume that
cannot assign to captured outer variable in an
FnMutclosure
refers to a specialty of FnMut closures. This change should make it clearer that the "immutable" is the key point here.
Note: I haven't checked in what other cases this message is emitted. It didn't seem to be covered by any existing borrowck compile-fail checks. But since the variant is called
MutabilityViolation
it seemed safe to add the "immutable".Fixes: #31871