Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for std::thread::sleep. #34406

Merged
merged 1 commit into from
Jun 28, 2016
Merged

Add example for std::thread::sleep. #34406

merged 1 commit into from
Jun 28, 2016

Conversation

frewsxcv
Copy link
Member

No description provided.

@frewsxcv
Copy link
Member Author

r? @steveklabnik

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jun 22, 2016

📌 Commit 0183f7f has been approved by GuillaumeGomez

@bors
Copy link
Contributor

bors commented Jun 22, 2016

⌛ Testing commit 0183f7f with merge 56854cb...

@bors
Copy link
Contributor

bors commented Jun 22, 2016

💔 Test failed - auto-linux-cross-opt

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Jun 22, 2016 at 9:50 AM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-cross-opt
http://buildbot.rust-lang.org/builders/auto-linux-cross-opt/builds/2712

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34406 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95EKdV2h3Yd5J6W3Fle1JqhDC5VPYks5qOWfqgaJpZM4I7VKV
.

@bors
Copy link
Contributor

bors commented Jun 22, 2016

⌛ Testing commit 0183f7f with merge 31b6756...

@bors
Copy link
Contributor

bors commented Jun 22, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@frewsxcv
Copy link
Member Author 

failures:

---- thread::sleep_0 stdout ----
    thread 'thread::sleep_0' panicked at 'test executable failed:

thread 'main' panicked at 'assertion failed: now.elapsed() > ten_millis', <anon>:11
note: Run with `RUST_BACKTRACE=1` for a backtrace.
', C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\librustdoc\test.rs:327
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Failure looks legit. But why?

@GuillaumeGomez
Copy link
Member

Good question. I tested it locally and it worked just fine.

@GuillaumeGomez
Copy link
Member

Maybe ">=" instead of ">"?

@frewsxcv
Copy link
Member Author

Updated to >=.

@GuillaumeGomez
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jun 23, 2016

📌 Commit bbc33ac has been approved by GuillaumeGomez

@bors
Copy link
Contributor

bors commented Jun 23, 2016

⌛ Testing commit bbc33ac with merge f33dd35...

@bors
Copy link
Contributor

bors commented Jun 23, 2016

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Jun 23, 2016 at 4:11 PM, bors notifications@github.com wrote:

💔 Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/9568

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34406 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95EffpUfsAAPURFcyjqZYWPc4qQjzks5qOxKlgaJpZM4I7VKV
.

@Manishearth Manishearth mentioned this pull request Jun 25, 2016
Merged
@Manishearth
Copy link
Member

http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1554

@frewsxcv
Copy link
Member Author

Is there a Windows bug with std::thread::sleep?

bors added a commit that referenced this pull request Jun 25, 2016
@bors
Auto merge of #34464 - Manishearth:rollup, r=Manishearth
b8214dc 
Rollup of 8 pull requests

- Successful merges: #34379, #34406, #34411, #34414, #34435, #34438, #34445, #34449
- Failed merges:
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 25, 2016
@GuillaumeGomez
Rollup merge of rust-lang#34406 - frewsxcv:sleep-ex, r=GuillaumeGomez
dfbf619 
Add example for `std::thread::sleep`.

None
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 25, 2016
Closed
@bors
Copy link
Contributor

bors commented Jun 25, 2016

⌛ Testing commit bbc33ac with merge cd0b94a...

@bors
Copy link
Contributor

bors commented Jun 25, 2016

💔 Test failed - auto-win-msvc-64-opt

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 27, 2016
@steveklabnik
Rollup merge of rust-lang#34406 - frewsxcv:sleep-ex, r=GuillaumeGomez
330fa40 
Add example for `std::thread::sleep`.

None
@steveklabnik steveklabnik mentioned this pull request Jun 27, 2016
Closed
@alexcrichton
Copy link
Member

We've discussed this a few times before, but could tests that purposefully block for a long time be tagged with no_run? It seems bad to forcefully cause the test suite to take longer :(

@frewsxcv
Copy link
Member Author

@alexcrichton Sure, I can do that, but should there be any concern about the test failing on the Windows builders?

@alexcrichton
Copy link
Member

Nah it's probably just spurious. Most assertions about intervals slept or things like that end up failing eventually. Time's weird.

@frewsxcv
Copy link
Member Author

Updated to use no_run.

@alexcrichton
Copy link
Member

@bors: r+ a7b9e54

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 27, 2016
@steveklabnik
Rollup merge of rust-lang#34406 - frewsxcv:sleep-ex, r=alexcrichton
71a97c0 
Add example for `std::thread::sleep`.

None
@steveklabnik steveklabnik mentioned this pull request Jun 27, 2016
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 28, 2016
@GuillaumeGomez
Rollup merge of rust-lang#34406 - frewsxcv:sleep-ex, r=alexcrichton
5d6b41f 
Add example for `std::thread::sleep`.

None
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 28, 2016
Merged
bors added a commit that referenced this pull request Jun 28, 2016
@bors
Auto merge of #34525 - GuillaumeGomez:rollup, r=GuillaumeGomez
59152a4 
Rollup of 13 pull requests

- Successful merges: #34080, #34287, #34328, #34406, #34415, #34442, #34462, #34471, #34475, #34479, #34517, #34518, #34524
- Failed merges: #33951
@bors bors merged commit a7b9e54 into rust-lang:master Jun 28, 2016
@frewsxcv frewsxcv deleted the sleep-ex branch October 2, 2016 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@frewsxcv @GuillaumeGomez @bors @alexcrichton @Manishearth @steveklabnik