Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate how the JoinHandle struct is created. #34438

Merged
merged 2 commits into from
Jun 25, 2016
Merged

Indicate how the JoinHandle struct is created. #34438

merged 2 commits into from
Jun 25, 2016

Conversation

frewsxcv
Copy link
Member

No description provided.

@frewsxcv
Copy link
Member Author

r? @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Adding an example on how it is created could be really nice (I like code examples).

@frewsxcv frewsxcv force-pushed the joinhandle branch 2 times, most recently from 0abe842 to 10ed0c2 Compare June 24, 2016 12:14
@frewsxcv
Copy link
Member Author

Examples added.

GuillaumeGomez
GuillaumeGomez reviewed Jun 24, 2016
View reviewed changes
src/libstd/thread/mod.rs
///
/// Creation from [`thread::spawn`]:
///
/// ```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add rust after "```". Example:

"```rust"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's optional, but sure, I can add it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err hold on.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an issue about it if I remember well. But thanks! :)

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jun 24, 2016

📌 Commit 5e9b75e has been approved by GuillaumeGomez

@Manishearth Manishearth mentioned this pull request Jun 25, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 25, 2016
@Manishearth
Rollup merge of rust-lang#34438 - frewsxcv:joinhandle, r=GuillaumeGomez
80b352c 
Indicate how the `JoinHandle` struct is created.

None
bors added a commit that referenced this pull request Jun 25, 2016
@bors
Auto merge of #34464 - Manishearth:rollup, r=Manishearth
b8214dc 
Rollup of 8 pull requests

- Successful merges: #34379, #34406, #34411, #34414, #34435, #34438, #34445, #34449
- Failed merges:
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 25, 2016
@GuillaumeGomez
Rollup merge of rust-lang#34438 - frewsxcv:joinhandle, r=GuillaumeGomez
d05a9c5 
Indicate how the `JoinHandle` struct is created.

None
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 25, 2016
Closed
@bors bors merged commit 5e9b75e into rust-lang:master Jun 25, 2016
@frewsxcv frewsxcv deleted the joinhandle branch October 2, 2016 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frewsxcv @GuillaumeGomez @bors