Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc examples for Vec::{as_slice,as_mut_slice}. #34930

Merged
merged 1 commit into from Jul 21, 2016
Merged

Add doc examples for Vec::{as_slice,as_mut_slice}. #34930

merged 1 commit into from Jul 21, 2016

Conversation

frewsxcv
Copy link
Member

No description provided.

steveklabnik
steveklabnik reviewed Jul 20, 2016
View reviewed changes
src/libcollections/vec.rs
/// ```
/// use std::io::{self, Write};
/// let buffer = vec![1, 2, 3, 5, 8];
/// let _ = io::sink().write(buffer.as_slice());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would prefer unwrap to let _, the former at least doesn't fail silently.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest force push switched to unwrap.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 20, 2016

📌 Commit 00e3149 has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Jul 20, 2016

⌛ Testing commit 00e3149 with merge 8a5e18e...

@bors
Copy link
Contributor

bors commented Jul 20, 2016

⛄ The build was interrupted to prioritize another pull request.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 20, 2016
Closed
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 20, 2016
Merged
@bors
Copy link
Contributor

bors commented Jul 21, 2016

⌛ Testing commit 00e3149 with merge 5a44bc9...

@bors
Copy link
Contributor

bors commented Jul 21, 2016

💔 Test failed - auto-linux-64-cargotest

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Jul 20, 2016 at 6:36 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-cargotest
https://buildbot.rust-lang.org/builders/auto-linux-64-cargotest/builds/1205

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34930 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95FrlPFl-Hia8wijC3LElyPwr9bRmks5qXs0QgaJpZM4JQUMB
.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 21, 2016
@GuillaumeGomez
Rollup merge of rust-lang#34930 - frewsxcv:vec-as-slice, r=steveklabnik
1006f79 
Add doc examples for `Vec::{as_slice,as_mut_slice}`.

None
bors added a commit that referenced this pull request Jul 21, 2016
@bors
Auto merge of #34939 - GuillaumeGomez:rollup, r=GuillaumeGomez
7588653 
Rollup of 7 pull requests

- Successful merges: #34854, #34855, #34880, #34895, #34911, #34921, #34930
- Failed merges: #33951, #34850
@bors bors merged commit 00e3149 into rust-lang:master Jul 21, 2016
@frewsxcv frewsxcv deleted the vec-as-slice branch October 2, 2016 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frewsxcv @steveklabnik @bors @alexcrichton