Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make .enumerate() example self-explanatory #34880

Merged
merged 1 commit into from Jul 21, 2016
Merged

Make .enumerate() example self-explanatory #34880

merged 1 commit into from Jul 21, 2016

Conversation

xitep
Copy link

@xitep xitep commented Jul 17, 2016

Should resolve #34624

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

thank you! Agree wholeheartedly/

@bors
Copy link
Contributor

bors commented Jul 18, 2016

📌 Commit 3b5d71e has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Jul 20, 2016

⌛ Testing commit 3b5d71e with merge 8f8a67d...

@bors
Copy link
Contributor

bors commented Jul 20, 2016

💔 Test failed - auto-win-msvc-64-cargotest

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Jul 19, 2016 at 9:53 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-cargotest
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/1170

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34880 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95NGhiP_qofZ7wYZmreMuOKlgEi2Mks5qXam-gaJpZM4JOMf-
.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 20, 2016
Closed
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 20, 2016
Merged
@bors
Copy link
Contributor

bors commented Jul 21, 2016

⌛ Testing commit 3b5d71e with merge b9f3ae5...

@bors
Copy link
Contributor

bors commented Jul 21, 2016

💔 Test failed - auto-linux-64-cargotest

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Jul 20, 2016 at 6:14 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-cargotest
https://buildbot.rust-lang.org/builders/auto-linux-64-cargotest/builds/1198

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34880 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95LclZItf6AdEz9qtBwB_l0p9xGS5ks5qXsfmgaJpZM4JOMf-
.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 21, 2016
@GuillaumeGomez
Rollup merge of rust-lang#34880 - xitep:master, r=steveklabnik
9ba1792 
Make .enumerate() example self-explanatory

Should resolve rust-lang#34624
bors added a commit that referenced this pull request Jul 21, 2016
@bors
Auto merge of #34939 - GuillaumeGomez:rollup, r=GuillaumeGomez
7588653 
Rollup of 7 pull requests

- Successful merges: #34854, #34855, #34880, #34895, #34911, #34921, #34930
- Failed merges: #33951, #34850
@bors bors merged commit 3b5d71e into rust-lang:master Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style of for loops enumeration example is unclear Ch. 4.6 of The Book.
5 participants
@xitep @rust-highfive @steveklabnik @bors @alexcrichton