intravisit: Fold functionality of IdVisitor into the regular Visitor. #35090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -814,6 +861,7 @@ pub fn walk_arm<'v, V: Visitor<'v>>(visitor: &mut V, arm: &'v Arm) { | |||
| } | |||
|
|
|||
| pub fn walk_vis<'v, V: Visitor<'v>>(visitor: &mut V, vis: &'v Visibility) { | |||
| // FIXME(mw): What is this NodeId in there? And should it be visited? | |||
There was a problem hiding this comment.
The path in visibility pub(path) has a resolution in def_map keyed by this id.
There was a problem hiding this comment.
OK, then we should visit it.
|
☔ The latest upstream changes (presumably #34956) made this pull request unmergeable. Please resolve the merge conflicts. |
michaelwoerister
force-pushed
the
get-rid-of-id-visitor
branch
from
fcee2ed
to
415fde4
Compare
|
@bors r+ |
|
📌 Commit 415fde4 has been approved by |
|
@bors: rollup assuming this isn't very platform-specific and green travis means it's good to go whenever |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 30, 2016
…tor, r=eddyb intravisit: Fold functionality of IdVisitor into the regular Visitor.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 30, 2016
…tor, r=eddyb intravisit: Fold functionality of IdVisitor into the regular Visitor.
bors
added a commit
that referenced
this pull request
Jul 30, 2016
sanxiyn
added a commit
to sanxiyn/rust
that referenced
this pull request
Aug 1, 2016
…-map, r=eddyb Move caching of inlined HIR into CrateStore So far we've had separate HIR-inlining caches for each codegen unit and the caching for things inlined during constant evaluation had some holes. Consequently, things would be inlined multiple times if they were used from different codegen units, etc, leading to - wasted memory, - multiple `NodeId`s per `DefId` and, - for things inlined during constant evaluation, no way to map a `NodeId` back to it's original `DefId`. This PR moves all caching into the CrateStore, solving all of the above problems. It also fixes some bugs in the inlining code, like cyclic in the parent-chains in the HIR map and some `NodeId`'s being translated to more or less random values. There are assertions in place now that should prevent this kind of thing in the future. This PR based on top of rust-lang#35090, which contains some necessary fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.