Test Case for Incr. Comp. Hash for enums #36674. #36840
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
This is excellent, thank you so much, @eulerdisk!
I've left two comments on things that should be fixed. After that this is good to merge 👍
| #[rustc_metadata_dirty(cfg="cfail2")] | ||
| #[rustc_metadata_clean(cfg="cfail3")] | ||
| enum EnumChangeFieldOrderStructStyleVariant { | ||
| Variant1 { b: u32, a: u32 }, |
| // We also test the ICH for struct definitions exported in metadata. Same as | ||
| // above, we want to make sure that the change between rev1 and rev2 also | ||
| // results in a change of the ICH for the struct's metadata, and that it stays | ||
| // the same between rev2 and rev3. |
There was a problem hiding this comment.
The comment paragraph above still says 'struct' instead of 'enum'.
|
@bors r+ Thanks @eulerdisk! |
|
📌 Commit 1a41138 has been approved by |
|
@michaelwoerister Maybe there's another "struct" to change in line 21 |
|
Yes, you're right, I'll fix it. |
|
@bors r- |
|
@bors r+ |
|
📌 Commit 16261a6 has been approved by |
|
⌛ Testing commit 16261a6 with merge 7b33876... |
…erister Test Case for Incr. Comp. Hash for enums #36674. Fixes #36674 Part of #36350 r? @michaelwoerister
|
🎉 |
Fixes #36674
Part of #36350
r? @michaelwoerister