Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `fmt::Debug` for strings, e.g. for Chinese characters #37855

Merged
merged 1 commit into from Nov 20, 2016

Conversation

@tbu-
Copy link
Contributor

@tbu- tbu- commented Nov 18, 2016

The problem occured due to lines like

3400;<CJK Ideograph Extension A, First>;Lo;0;L;;;;;N;;;;;
4DB5;<CJK Ideograph Extension A, Last>;Lo;0;L;;;;;N;;;;;

in UnicodeData.txt, which the script previously interpreted as two
characters, although it represents the whole range.

Fixes #34318.

The problem occured due to lines like

```
3400;<CJK Ideograph Extension A, First>;Lo;0;L;;;;;N;;;;;
4DB5;<CJK Ideograph Extension A, Last>;Lo;0;L;;;;;N;;;;;
```

in `UnicodeData.txt`, which the script previously interpreted as two
characters, although it represents the whole range.

Fixes #34318.
@rust-highfive
Copy link
Collaborator

@rust-highfive rust-highfive commented Nov 18, 2016

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@tbu-
Copy link
Contributor Author

@tbu- tbu- commented Nov 18, 2016

I also added a little test for this new behavior.

CC @liigo
r? @alexcrichton

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Nov 18, 2016

@bors: r+

@bors
Copy link
Contributor

@bors bors commented Nov 18, 2016

📌 Commit d0bb7e1 has been approved by alexcrichton

@bors
Copy link
Contributor

@bors bors commented Nov 20, 2016

Testing commit d0bb7e1 with merge 224f2ce...

bors added a commit that referenced this pull request Nov 20, 2016
Fix `fmt::Debug` for strings, e.g. for Chinese characters

The problem occured due to lines like

```
3400;<CJK Ideograph Extension A, First>;Lo;0;L;;;;;N;;;;;
4DB5;<CJK Ideograph Extension A, Last>;Lo;0;L;;;;;N;;;;;
```

in `UnicodeData.txt`, which the script previously interpreted as two
characters, although it represents the whole range.

Fixes #34318.
@bors bors merged commit d0bb7e1 into rust-lang:master Nov 20, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test successful
Details
@bluss bluss added the relnotes label Nov 20, 2016
@liigo
Copy link
Contributor

@liigo liigo commented Nov 23, 2016

@tbu- Nice work! I'v double checked in Chinese Windows. This PR did fixed #34318. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.