Fix a bug where read(buf, len) would fail if buf was big enough and ... #4029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucceed if it was too small ... which is the opposite of correct.
catamorphism
added a commit
that referenced
this pull request
Nov 24, 2012
Fix a bug where read(buf, len) would fail if buf was big enough and ...
|
Good catch, thanks! |
|
This seems to fail on Windows but pass on the other platforms. I don't have access to a Windows machine right now to figure out why. |
|
Probably because there's a |
|
Just curious, why does it need to be ignored on windows? |
|
@Dretch Task unwinding doesn't work on Windows so any task failure is fatal. Therefore all failure tests are disabled on windows. It's a huge bug. |
|
Oh, thanks @brson, I had no idea. |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
succeed if it was too small ... which is the opposite of correct.
I might be missing something but I think this is a bug.