Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change string references in asciiext #40837

Merged
merged 2 commits into from Mar 29, 2017
Merged

change string references in asciiext #40837

merged 2 commits into from Mar 29, 2017

Conversation

alanstoate
Copy link
Contributor

#40714 Updated AsciiExt docs and some examples

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alanstoate alanstoate changed the title change string references in asciiext r? @steveklabnik change string references in asciiext Mar 26, 2017
asgs
asgs reviewed Mar 26, 2017
View reviewed changes
Copy link

@asgs asgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment: change "it's" to its

frewsxcv
frewsxcv suggested changes Mar 26, 2017
View reviewed changes
Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Just need to fix a couple typos then this should be good to go!

src/libstd/ascii.rs Outdated
/// ```
#[stable(feature = "rust1", since = "1.0.0")]
fn is_ascii(&self) -> bool;

/// Makes a copy of the string in ASCII upper case.
/// Makes a copy of the value in it's ASCII upper case equivalent.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"it's" → "its"

http://www.its-not-its.info/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, well that's embarrassing. Fixed now :)

src/libstd/ascii.rs Outdated
/// ```
///
/// [`make_ascii_uppercase`]: #tymethod.make_ascii_uppercase
/// [`str::to_uppercase`]: ../primitive.str.html#method.to_uppercase
#[stable(feature = "rust1", since = "1.0.0")]
fn to_ascii_uppercase(&self) -> Self::Owned;

/// Makes a copy of the string in ASCII lower case.
/// Makes a copy of the value in it's ASCII lower case equivalent.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto about "it's"

@steveklabnik
Copy link
Member

@bors: r+ rollup

thanks a ton! ❤️

@bors
Copy link
Contributor

bors commented Mar 27, 2017

📌 Commit 1579fbd has been approved by steveklabnik

@alexcrichton
Copy link
Member

r? @steveklabnik

@alexcrichton alexcrichton mentioned this pull request Mar 27, 2017
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2017
@alexcrichton
Rollup merge of rust-lang#40837 - alanstoate:ascii-docs, r=steveklabnik
498da9f 
change string references in asciiext
bors added a commit that referenced this pull request Mar 27, 2017
@bors
Auto merge of #40867 - alexcrichton:rollup, r=alexcrichton
32a2d73 
Rollup of 19 pull requests

- Successful merges: #40317, #40516, #40524, #40606, #40683, #40751, #40778, #40813, #40818, #40819, #40824, #40828, #40832, #40833, #40837, #40849, #40852, #40853, #40865
- Failed merges:
bors added a commit that referenced this pull request Mar 28, 2017
@bors
Auto merge of #40867 - alexcrichton:rollup, r=alexcrichton
07a3429 
Rollup of 19 pull requests

- Successful merges: #40317, #40516, #40524, #40606, #40683, #40751, #40778, #40813, #40818, #40819, #40824, #40828, #40832, #40833, #40837, #40849, #40852, #40853, #40865
- Failed merges:
@bors bors merged commit 1579fbd into rust-lang:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgs asgs asgs left review comments

@frewsxcv frewsxcv frewsxcv requested changes

Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alanstoate @rust-highfive @steveklabnik @bors @alexcrichton @frewsxcv @asgs