-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: finalize resolutions of macros in trait positions #40849
Merged
bors
merged 1 commit into
rust-lang:master
from
jseyfried:finalize_trait_macro_resolutions
Mar 29, 2017
Merged
bugfix: finalize resolutions of macros in trait positions #40849
bors
merged 1 commit into
rust-lang:master
from
jseyfried:finalize_trait_macro_resolutions
Mar 29, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseyfried
commented
Mar 27, 2017
@@ -172,7 +172,6 @@ impl<'a> base::Resolver for Resolver<'a> { | |||
expansion: mark, | |||
}; | |||
expansion.visit_with(&mut visitor); | |||
self.current_module.unresolved_invocations.borrow_mut().remove(&mark); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated: remove duplicated line (always a no-op)
@bors: r+ |
📌 Commit 737511e has been approved by |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 27, 2017
…lutions, r=nrc bugfix: finalize resolutions of macros in trait positions Fixes rust-lang#40845. r? @nrc
bors
added a commit
that referenced
this pull request
Mar 27, 2017
bors
added a commit
that referenced
this pull request
Mar 28, 2017
Accepting for beta. Small patch, regression. cc @rust-lang/compiler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40845.
r? @nrc