Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper span for tuple index parsed as float #41087

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Use proper span for tuple index parsed as float #41087

merged 1 commit into from
Apr 12, 2017

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Apr 5, 2017

Fix diagnostic suggestion from:

help: try parenthesizing the first index
  |     (1, (2, 3)).((1, (2, 3)).1).1;

to the correct:

help: try parenthesizing the first index
  |     ((1, (2, 3)).1).1;

Fix #41081.

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank estebank mentioned this pull request Apr 5, 2017
Closed
@estebank
Use proper span for tuple index parsed as float
44e414c 
Fix diagnostic suggestion from:

```rust
help: try parenthesizing the first index
  |     (1, (2, 3)).((1, (2, 3)).1).1;
```

to the correct:

```rust
help: try parenthesizing the first index
  |     ((1, (2, 3)).1).1;
```
@estebank
Copy link
Contributor Author

estebank commented Apr 9, 2017

r? @arielb1 short review

@rust-highfive rust-highfive assigned arielb1 and unassigned pnkfelix Apr 9, 2017
@estebank
Copy link
Contributor Author

Ping.

@arielb1
Copy link
Contributor

arielb1 commented Apr 12, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 12, 2017

📌 Commit 44e414c has been approved by arielb1

TimNN added a commit to TimNN/rust that referenced this pull request Apr 12, 2017
@TimNN
Rollup merge of rust-lang#41087 - estebank:tuple-float-index, r=arielb1
918e35a 
Use proper span for tuple index parsed as float

Fix diagnostic suggestion from:

```rust
help: try parenthesizing the first index
  |     (1, (2, 3)).((1, (2, 3)).1).1;
```

to the correct:

```rust
help: try parenthesizing the first index
  |     ((1, (2, 3)).1).1;
```

Fix rust-lang#41081.
@TimNN TimNN mentioned this pull request Apr 12, 2017
Merged
bors added a commit that referenced this pull request Apr 12, 2017
@bors
Auto merge of #41246 - TimNN:rollup, r=TimNN
910c481 
Rollup of 9 pull requests

- Successful merges: #41063, #41087, #41141, #41166, #41183, #41205, #41206, #41232, #41243
- Failed merges:
@bors bors merged commit 44e414c into rust-lang:master Apr 12, 2017
@durka durka mentioned this pull request Apr 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estebank @rust-highfive @arielb1 @bors @pnkfelix