Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -march=armv7-a parameter to armv7 android linker #41657

Merged
merged 1 commit into from
May 3, 2017

Conversation

malbarbo
Copy link
Contributor

Without this option, the linker fails to link any library that uses std::future. The error points some undefined references, like std::__future_base::_Result_base.

For example, it fails to link rustc because llvm 4.0 uses std::future.

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64735

@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2017
@arielb1
Copy link
Contributor

arielb1 commented May 2, 2017

r? @japaric you understand ARM better than I do

@rust-highfive rust-highfive assigned japaric and unassigned arielb1 May 2, 2017
@arielb1
Copy link
Contributor

arielb1 commented May 2, 2017

Thanks for the PR @malbarbo. @japaric or someone else should be reviewing your PR shortly.

@malbarbo
Copy link
Contributor Author

malbarbo commented May 2, 2017

Here is a script to reproduce the problem. It is necessary to have ndk installed and the android gcc compilers on path.

@alexcrichton
Copy link
Member

@bors: r+

Thanks @malbarbo!

@bors
Copy link
Contributor

bors commented May 2, 2017

📌 Commit 9896483 has been approved by alexcrichton

@alexcrichton alexcrichton added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 3, 2017
…excrichton

Add -march=armv7-a parameter to armv7 android linker

Without this option, the linker fails to link any library that uses `std::future`. The error points some undefined references, like `std::__future_base::_Result_base`.

For example, it fails to link rustc because llvm 4.0 uses `std::future`.

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64735
bors added a commit that referenced this pull request May 3, 2017
Rollup of 7 pull requests

- Successful merges: #41217, #41625, #41640, #41653, #41656, #41657, #41705
- Failed merges:
@bors bors merged commit 9896483 into rust-lang:master May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants