Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ANTLR grammar #41705

Merged
merged 1 commit into from May 3, 2017
Merged

Remove ANTLR grammar #41705

merged 1 commit into from May 3, 2017

Conversation

Mark-Simulacrum
Copy link
Member

I think that nothing in-tree references this, but I may be wrong. If anyone thinks of anything, please let me know and I'll work on removing.

Fixes #15677.

@Mark-Simulacrum
Remove ANTLR grammar.
c3781e6 
It is unused and not maintained.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 2, 2017

📌 Commit c3781e6 has been approved by nikomatsakis

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 3, 2017
@frewsxcv
Rollup merge of rust-lang#41705 - Mark-Simulacrum:remove-grammar, r=n…
2b51384 
…ikomatsakis

Remove ANTLR grammar

I *think* that nothing in-tree references this, but I may be wrong. If anyone thinks of anything, please let me know and I'll work on removing.

Fixes rust-lang#15677.
@frewsxcv frewsxcv mentioned this pull request May 3, 2017
Merged
bors added a commit that referenced this pull request May 3, 2017
@bors
Auto merge of #41717 - frewsxcv:rollup, r=frewsxcv
146dc67 
Rollup of 7 pull requests

- Successful merges: #41217, #41625, #41640, #41653, #41656, #41657, #41705
- Failed merges:
@bors bors merged commit c3781e6 into rust-lang:master May 3, 2017
@nagisa
Copy link
Member

nagisa commented May 7, 2017

This PR also removes the YACC grammar, which is independent of the ANTLR one and should have been left intact?

@Mark-Simulacrum
Copy link
Member Author

I'd be happy to undo parts of this PR, however I'm not certain what files the YACC grammar consisted of. Could you specify those? I'll put up a PR restoring them.

@Mark-Simulacrum Mark-Simulacrum deleted the remove-grammar branch May 7, 2017 23:44
@nagisa
Copy link
Member

nagisa commented May 8, 2017 •
edited

At least parser-lalr-yaml.c, the .y and .l file, probably the .h file too. The .py script might have been used for lalr, though not entirely sure. Also would be great to keep the string ambiguity text.

ANTLR grammar is .g4, verify.rs, shell script and README.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 8, 2017
Merged
bors added a commit that referenced this pull request May 8, 2017
@bors
Auto merge of #41824 - Mark-Simulacrum:undo-yacc-removal, r=nagisa
20de961 
Readd LALR grammar

Reverts a portion of #41705. Please let me know if I missed anything.

r? @nagisa
@est31 est31 mentioned this pull request Aug 30, 2017
Closed
@ehuss ehuss mentioned this pull request Oct 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Mark-Simulacrum @rust-highfive @nikomatsakis @bors @nagisa