Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reenable opt-level 3" #42123

Merged
merged 1 commit into from
May 20, 2017
Merged

Conversation

Mark-Simulacrum
Copy link
Member

This reverts commit 30383b2, from #41967.

We believe that this is causing the failures when compiling rustc on 64 bit (which are probably segfaults).

cc @ishitatsuyuki

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ p=1

Let's see if this prevents the segfaults, and if so we can chalk it up to LLVM but if not we can revert this PR and keep investigating.

@bors
Copy link
Contributor

bors commented May 20, 2017

📌 Commit 409d40f has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 20, 2017

⌛ Testing commit 409d40f with merge 1cda810...

bors added a commit that referenced this pull request May 20, 2017
Revert "Reenable opt-level 3"

This reverts commit 30383b2, from #41967.

We believe that this is causing the failures when compiling rustc on 64 bit (which are probably segfaults).

cc @ishitatsuyuki
@bors
Copy link
Contributor

bors commented May 20, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1cda810 to master...

@bors bors merged commit 409d40f into rust-lang:master May 20, 2017
bors added a commit that referenced this pull request Jul 11, 2018
Set opt-level = 3 the third time.

This PR reverts #51165 (set -O2 to fix #50867),
which reverted #50329 (set -O3),
which was second attempt of #48204 (set -O3, closed due to Windows segfault that is fixed now),
which reverted #42123 (set -O2 to fix spurious Windows segfaults),
which reverted #41967 (set -O3).

Last time we've found that setting -O3 regressed the wall time of NLL (#50329 (comment)), so we may need another perf run to confirm. I'd like to check this *after* the LLVM 7 upgrade #51966 has been merged, so marking this as <kbd>S-blocked</kbd> for now.
bors added a commit that referenced this pull request Jul 14, 2018
Set opt-level = 3 the third time.

This PR reverts #51165 (set -O2 for fixing #50867),
which reverted #50329 (set -O3),
which was second attempt of #48204 (set -O3, closed due to Windows segfault that is fixed now),
which reverted #42123 (set -O2 to fix spurious Windows segfaults),
which reverted #41967 (set -O3).

Since we have found the root cause of #50867, this optimization could be tried again.

Last time we've found that setting -O3 regressed the wall time of NLL (#50329 (comment)), so we may need another perf run to confirm. I'd like to check this *after* the LLVM 7 upgrade #51966 has been merged, so marking this as <kbd>S-blocked</kbd> for now.
@Mark-Simulacrum Mark-Simulacrum deleted the revert-41967 branch June 8, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants