New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CXX_<target> in bootstrap #42829

Merged
merged 2 commits into from Jun 23, 2017

Conversation

Projects
None yet
5 participants
@ids1024
Contributor

ids1024 commented Jun 22, 2017

I came across this trying to cross-compile rustc for Redox. It was also mentioned in a comment on #42206, but doesn't seem to have been corrected.

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Jun 22, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Jun 22, 2017

Thanks for the PR! I think though that this'll need to be conditional as accessing the cxx method can panic for non-host targets. Mind either changing cxx to return an Option or have a similar check?

@ids1024

This comment has been minimized.

Contributor

ids1024 commented Jun 22, 2017

I've made it return a Result, since unwrapping an Option wouldn't provide a useful error message.

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Jun 22, 2017

@bors: r+

Thanks!

@bors

This comment has been minimized.

Contributor

bors commented Jun 22, 2017

📌 Commit f98ffb5 has been approved by alexcrichton

@Mark-Simulacrum

This comment has been minimized.

Member

Mark-Simulacrum commented Jun 22, 2017

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 22, 2017

Rollup merge of rust-lang#42829 - ids1024:cxx, r=alexcrichton
Set CXX_<target> in bootstrap

I came across this trying to cross-compile rustc for Redox. It was also mentioned in a comment on rust-lang#42206, but doesn't seem to have been corrected.

bors added a commit that referenced this pull request Jun 23, 2017

Auto merge of #42845 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 9 pull requests

- Successful merges: #42724, #42777, #42783, #42787, #42821, #42822, #42825, #42829, #42833
- Failed merges:

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 23, 2017

Rollup merge of rust-lang#42829 - ids1024:cxx, r=alexcrichton
Set CXX_<target> in bootstrap

I came across this trying to cross-compile rustc for Redox. It was also mentioned in a comment on rust-lang#42206, but doesn't seem to have been corrected.

bors added a commit that referenced this pull request Jun 23, 2017

Auto merge of #42846 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 8 pull requests

- Successful merges: #42724, #42783, #42787, #42821, #42822, #42825, #42829, #42833
- Failed merges:

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 23, 2017

Rollup merge of rust-lang#42829 - ids1024:cxx, r=alexcrichton
Set CXX_<target> in bootstrap

I came across this trying to cross-compile rustc for Redox. It was also mentioned in a comment on rust-lang#42206, but doesn't seem to have been corrected.

bors added a commit that referenced this pull request Jun 23, 2017

Auto merge of #42856 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 8 pull requests

- Successful merges: #42777, #42783, #42787, #42821, #42822, #42825, #42829, #42833
- Failed merges:

bors added a commit that referenced this pull request Jun 23, 2017

Auto merge of #42856 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Rollup of 8 pull requests

- Successful merges: #42777, #42783, #42787, #42821, #42822, #42825, #42829, #42833
- Failed merges:

@bors bors merged commit f98ffb5 into rust-lang:master Jun 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ids1024 ids1024 deleted the ids1024:cxx branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment