Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Travis CI job order. #43287

Merged
merged 1 commit into from Jul 19, 2017

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
7 participants
@kennytm @rust-highfive @alexcrichton @bors @aidanhs @Mark-Simulacrum @arielb1
@kennytm
Copy link
Member

kennytm commented Jul 17, 2017 •
edited

Reorder the job matrix to take advantage of the order how Travis CI starts them in rust-lang/rust. Plus other refactoring of .travis.yml.

  1. Move the $ALLOW_PR image to the top, so pull requests will start testing as immediately after the build is started. Previously the $ALLOW_PR image starts 6 minutes after the build was scheduled.

  2. Move the slow macOS images near the top, so they share more time with the rest of the faster Linux builds, which should shorten total test time (actually not much, about 7 minutes at most if this change does work).

  3. Merged the install section of both Linux and macOS to make the env: section a bit shorter, and enable change 4 below.

  4. Do not download or install anything if $SKIP_BUILD == true, which further reduces chance of spurious failure in the PR-CI stage (avoid the red cross appearing even if CI passed).

(IMO $SKIP_BUILD should not even exist: those irrelevant jobs should not start at all, but that would require travis-ci/travis-ci#2778 which has been rejected)

@rust-highfive rust-highfive assigned alexcrichton Jul 17, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jul 17, 2017

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)
@kennytm

This comment has been minimized.

Sign in to view
Copy link
Member Author

kennytm commented Jul 17, 2017

(In the Travis CI PR build of this commit, 9 minutes and 6 minutes are respectively taken to skip two macOS builds. Both are due to git fetch origin +refs/pull/43287/merge becoming very slow, which seems to be a problem of Travis's "Partially Degraded Service" with GitHub, not a problem of this PR.)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jul 17, 2017

@bors: r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 17, 2017

📌 Commit d19ae39 has been approved by alexcrichton

bors added a commit that referenced this pull request Jul 18, 2017

@bors
Auto merge of #43287 - kennytm:travis-ci-adjustments, r=alexcrichton 
Change Travis CI job order.

Reorder the job matrix to take advantage of the order how Travis CI starts them in rust-lang/rust. Plus other refactoring of `.travis.yml`.

1. Move the `$ALLOW_PR` image to the top, so pull requests will start testing as immediately after the build is started. Previously the `$ALLOW_PR` image starts 6 minutes after the build was scheduled.

2. Move the slow macOS images near the top, so they share more time with the rest of the faster Linux builds, which should shorten total test time (actually not much, about 7 minutes at most if this change does work).

3. Merged the `install` section of both Linux and macOS to make the `env:` section a bit shorter, and enable change 4 below.

4. Do not download or install anything if `$SKIP_BUILD == true`, which further reduces chance of spurious failure in the PR-CI stage (avoid the red cross appearing even if CI passed).

(IMO `$SKIP_BUILD` should not even exist: those irrelevant jobs should not start at all, but that would require travis-ci/travis-ci#2778 which has been rejected)
Loading status checks…
299836d
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 18, 2017

⌛️ Testing commit d19ae39 with merge 299836d...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 18, 2017

💔 Test failed - status-travis
@kennytm

This comment has been minimized.

Sign in to view
Copy link
Member Author

kennytm commented Jul 18, 2017

Failed to download sccache. Spurious. But let's not retry since #43293 will conflict with this anyway.
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 18, 2017

☔️ The latest upstream changes (presumably #43293) made this pull request unmergeable. Please resolve the merge conflicts.
@kennytm
Change Travis CI job order. 
Reorder the job matrix to take advantage of the order how Travis CI starts
them in rust-lang/rust. Plus other refactoring of `.travis.yml`.

1. Move the `$ALLOW_PR` image to the top, so users' PRs will start testing
   immediately. Previously the `$ALLOW_PR` image starts 6 minutes after the
   build was scheduled.

2. Move the slow macOS images near the top, so they share more time with
   the rest of the faster Linux builds, which should shorten total test
   time (actually not much, about 7 minutes at most if this change does
   work).

3. Merged the `install` section of both Linux and macOS to make the `env:`
   section a bit shorter, and enable change 4 below.

4. Do not download or install anything if `$SKIP_BUILD == true`, which
   further reduces chance of spurious failure in the PR-CI stage (avoid the
   red cross appearing even if CI passed).
Verified
This commit was signed with a verified signature.
@kennytm kennytm
GPG key ID: FEF6C8051D0E013C Learn about signing commits
Loading status checks…
a7eb87e

@kennytm kennytm force-pushed the kennytm:travis-ci-adjustments branch from d19ae39 to a7eb87e Jul 18, 2017

@kennytm

This comment has been minimized.

Sign in to view
Copy link
Member Author

kennytm commented Jul 18, 2017

Rebased. @alexcrichton
@aidanhs

This comment has been minimized.

Sign in to view
Copy link
Member

aidanhs commented Jul 18, 2017

Hmm, I'm a bit confused. Looking at the log it didn't even try to download sccache, which is reasonable because it should be cached in the docker image. So what's up with

[00:02:37]   /usr/local/bin/sccache: 2: /usr/local/bin/sccache: Syntax error: newline
[00:02:37]   unexpected

?
@aidanhs

This comment has been minimized.

Sign in to view
Copy link
Member

aidanhs commented Jul 18, 2017

Right I see, a failed curl in a different build polluted our docker cache until #43293 was made to fix it, and this build was one of the casualties.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jul 18, 2017

@bors: r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 18, 2017

📌 Commit a7eb87e has been approved by alexcrichton
@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
Member

Mark-Simulacrum commented Jul 18, 2017

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 18, 2017

@Mark-Simulacrum
Rollup merge of rust-lang#43287 - kennytm:travis-ci-adjustments, r=al… 
…excrichton

Change Travis CI job order.

Reorder the job matrix to take advantage of the order how Travis CI starts them in rust-lang/rust. Plus other refactoring of `.travis.yml`.

1. Move the `$ALLOW_PR` image to the top, so pull requests will start testing as immediately after the build is started. Previously the `$ALLOW_PR` image starts 6 minutes after the build was scheduled.

2. Move the slow macOS images near the top, so they share more time with the rest of the faster Linux builds, which should shorten total test time (actually not much, about 7 minutes at most if this change does work).

3. Merged the `install` section of both Linux and macOS to make the `env:` section a bit shorter, and enable change 4 below.

4. Do not download or install anything if `$SKIP_BUILD == true`, which further reduces chance of spurious failure in the PR-CI stage (avoid the red cross appearing even if CI passed).

(IMO `$SKIP_BUILD` should not even exist: those irrelevant jobs should not start at all, but that would require travis-ci/travis-ci#2778 which has been rejected)
6a56671

@Mark-Simulacrum Mark-Simulacrum referenced this pull request Jul 18, 2017

Merged

Rollup of 11 pull requests #43316

bors added a commit that referenced this pull request Jul 18, 2017

@bors
Auto merge of #43316 - Mark-Simulacrum:rollup, r=Mark-Simulacrum 
Rollup of 11 pull requests

- Successful merges: #42837, #43282, #43287, #43290, #43292, #43294, #43304, #43310, #43312, #43314, #43315
- Failed merges:
Loading status checks…
ff1c517

bors added a commit that referenced this pull request Jul 18, 2017

@bors
Auto merge of #43316 - Mark-Simulacrum:rollup, r=Mark-Simulacrum 
Rollup of 11 pull requests

- Successful merges: #42837, #43282, #43287, #43290, #43292, #43294, #43304, #43310, #43312, #43314, #43315
- Failed merges:
Loading status checks…
af049cd

@arielb1 arielb1 added the S-waiting-on-bors label Jul 18, 2017

@bors bors merged commit a7eb87e into rust-lang:master Jul 19, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kennytm kennytm deleted the kennytm:travis-ci-adjustments branch Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.