Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Remove some dead code #43986

Merged
merged 1 commit into from
Aug 21, 2017
Merged

rustc: Remove some dead code #43986

merged 1 commit into from
Aug 21, 2017

Conversation

petrochenkov
Copy link
Contributor

Extracted from #43192

r? @eddyb

/// data of *which* particular statement causing the deinitialization
/// that the borrow checker's error message may need to report.
#[allow(dead_code)]
pub struct MovingOutStatements<'a, 'tcx: 'a> {
Copy link
Member

@eddyb eddyb Aug 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be used by MIR borrowck.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its okay, this is easy to put back when the time comes.

@eddyb
Copy link
Member

eddyb commented Aug 19, 2017

r? @pnkfelix

@rust-highfive rust-highfive assigned pnkfelix and unassigned eddyb Aug 19, 2017
@eddyb
Copy link
Member

eddyb commented Aug 19, 2017

LGTM except for some MIR changes - I'm not sure if anyone has plans for that code.

/// constraint, and the nodes themselves are associated with
/// variables or other bitsets. This method facilitates such a
/// computation.
pub fn iterate_until_fixed_point<'a, F>(&'a self, mut op: F)
Copy link
Member

@pnkfelix pnkfelix Aug 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was pretty surprised that this is dead code. But as far as I can tell, #7688 introduced it alongside with another fixed-point iteration function definition (specialized to region inference alone) ... and I guess no one ended up ever invoking the one that used the new graph abstraction ... Maybe that was meant to be future work that never got done? Anyway, I don't object to removing it now.

@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 21, 2017

📌 Commit de4dbe5 has been approved by pnkfelix

@bors
Copy link
Contributor

bors commented Aug 21, 2017

⌛ Testing commit de4dbe5 with merge 757b7ac...

bors added a commit that referenced this pull request Aug 21, 2017
rustc: Remove some dead code

Extracted from #43192

r? @eddyb
@bors
Copy link
Contributor

bors commented Aug 21, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing 757b7ac to master...

@bors bors merged commit de4dbe5 into rust-lang:master Aug 21, 2017
This was referenced Aug 21, 2017
@petrochenkov petrochenkov deleted the pubcrate3 branch August 26, 2017 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants