Mir borrowck as query #44009
Merged
Mir borrowck as query #44009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
arielb1
reviewed
Aug 21, 2017
| @@ -923,6 +923,8 @@ define_maps! { <'tcx> | |||
| [] coherent_trait: coherent_trait_dep_node((CrateNum, DefId)) -> (), | |||
|
|
|||
| [] borrowck: BorrowCheck(DefId) -> (), | |||
| // FIXME: shouldn't this return a `Result<(), BorrowckErrors>` instead? | |||
There was a problem hiding this comment.
We'll figure out the borrowck error story.
|
@bors r+ |
|
📌 Commit c9597ff has been approved by |
|
☔ The latest upstream changes (presumably #43986) made this pull request unmergeable. Please resolve the merge conflicts. |
(A followup commit removes the mir::transform based entry point.)
pnkfelix
force-pushed
the
mir-borrowck-as-query
branch
from
c9597ff
to
d92c953
Compare
|
@bors r=arielb1 |
|
📌 Commit d92c953 has been approved by |
|
@bors cancel |
pnkfelix
force-pushed
the
mir-borrowck-as-query
branch
from
d92c953
to
224c6ca
Compare
|
@bors r=arielb1 |
|
📌 Commit 224c6ca has been approved by |
|
⌛ Testing commit 224c6ca with merge c326ad220ae5712937c8ee8085a074ebe1ff3fe0... |
|
💔 Test failed - status-travis |
|
@bors retry Build canceled without any reason. |
bors
added a commit
that referenced
this pull request
Aug 21, 2017
Mir borrowck as query Turn the `mir-borrowck` pass (aka "transform") into a query. (If I had realized how relatively easy this was going to be, I would have made it part of #43108. `let hindsight = 20/20;`)
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Aug 21, 2017
Merged
bors
added a commit
that referenced
this pull request
Aug 22, 2017
Fix logic error in test guarding prototype MIR borrowck code. Fix logic error in test guarding prototype MIR borrowck code. tl;dr: 🤦 (This crept in during the shift from a transform to a query (#44009); I didn't notice because my muscle memory was still always passing `-Z mir-borrowck`, while my test cases *also* had the `#[rustc_mir_borrowck]` attribute attached to them.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn the
mir-borrowckpass (aka "transform") into a query.(If I had realized how relatively easy this was going to be, I would have made it part of #43108.
let hindsight = 20/20;)