Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: fix dist in debug mode #45382

Merged
merged 1 commit into from Oct 19, 2017
Merged

rustbuild: fix dist in debug mode #45382

merged 1 commit into from Oct 19, 2017

Conversation

Keruspe
Copy link
Contributor

@Keruspe Keruspe commented Oct 19, 2017 •
edited

In debug mode, the artifacts are placed in "debug", so don't hardcode "release" and use our helper to get the right directory name

@Keruspe
rustbuild: fix dist in debug mode
27cc119 
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2017
@Mark-Simulacrum
Copy link
Member

However, I will note that distributing a debug compiler is almost certainly not what you want to do, since it will be very slow (10x or more, last I heard).

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 19, 2017

📌 Commit 27cc119 has been approved by Mark-Simulacrum

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2017
@Keruspe
Copy link
Contributor Author

Keruspe commented Oct 19, 2017

Would definitely not recommend that for production, but useful to get nice stacks in case of a segfault

@Mark-Simulacrum
Copy link
Member

To an extent, though usually not worth it. rustc, thankfully, rarely segfaults.

@kennytm kennytm mentioned this pull request Oct 19, 2017
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Oct 19, 2017
@kennytm
Rollup merge of rust-lang#45382 - Keruspe:master, r=Mark-Simulacrum
4371862 
rustbuild: fix dist in debug mode

In debug mode, the artifacts are placed in "debug", so don't hardcode "release" and use our helper to get the right directory name
bors added a commit that referenced this pull request Oct 19, 2017
@bors
Auto merge of #45386 - kennytm:rollup, r=kennytm
439f752 
Rollup of 8 pull requests

- Successful merges: #45343, #45349, #45352, #45374, #45375, #45376, #45377, #45382
- Failed merges:
@bors bors merged commit 27cc119 into rust-lang:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Keruspe @Mark-Simulacrum @bors @kennytm