Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do match-check for consts #46033

Merged
merged 6 commits into from
Nov 26, 2017
Merged

Do match-check for consts #46033

merged 6 commits into from
Nov 26, 2017

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Nov 16, 2017 •
edited
Loading

Fixes #43195 (ICE caused by building MIR that contains non-exausitive match)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2017
@arielb1
Copy link
Contributor

arielb1 commented Nov 16, 2017

@sinkuu

Could you turn match checking into a query so that it will always be executed once?

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2017
@kennytm
Copy link
Member

kennytm commented Nov 22, 2017

Hi @sinkuu, @arielb1 have got some comments on this PR 🙂

@sinkuu
Copy link
Contributor Author

sinkuu commented Nov 23, 2017

Sorry for silence, I'll try in the weekend.

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2017
@arielb1
Copy link
Contributor

arielb1 commented Nov 25, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Nov 25, 2017

📌 Commit 62cb74a has been approved by arielb1

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2017
@bors
Copy link
Contributor

bors commented Nov 26, 2017

⌛ Testing commit 62cb74a with merge 2f84fb5...

bors added a commit that referenced this pull request Nov 26, 2017
@bors
Auto merge of #46033 - sinkuu:const-enum-match-check, r=arielb1
2f84fb5 
Do match-check for consts

Fixes #43195 (ICE caused by building MIR that contains non-exausitive match)
@bors
Copy link
Contributor

bors commented Nov 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing 2f84fb5 to master...

@bors bors merged commit 62cb74a into rust-lang:master Nov 26, 2017
@sinkuu sinkuu deleted the const-enum-match-check branch November 26, 2017 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sinkuu @arielb1 @kennytm @bors