rustdoc: Fix link title rendering with hoedown #47855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
LGTM but could use a test |
kennytm
added
the
S-waiting-on-author
ollie27
force-pushed
the
rustdoc_hoedown_link_title
branch
from
3a5b7b6
to
26b1d43
Compare
|
added test |
|
As-is, the test just makes sure that the link doesn't change between the renderers. Once we take Hoedown out, that test will not do anything (and will actually fail because we'll probably take that flag out at the same time). Can you add a |
The link title needs to be HTML escaped.
ollie27
force-pushed
the
rustdoc_hoedown_link_title
branch
from
26b1d43
to
ae98f4c
Compare
|
I've updated the test to use |
|
Ah, i missed where the change was happening in. In any case, we can keep this around to make sure we (or Pulldown?) don't mess this up in the future. @bors r+ rollup |
|
📌 Commit ae98f4c has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 30, 2018
… r=QuietMisdreavus rustdoc: Fix link title rendering with hoedown The link title needs to be HTML escaped. It was broken by rust-lang#47046. r? @QuietMisdreavus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link title needs to be HTML escaped.
It was broken by #47046.
r? @QuietMisdreavus