Run rustfmt and add doc comments to libsyntax/ext/tt/macro_parser.rs #47732
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
kennytm
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #47748) made this pull request unmergeable. Please resolve the merge conflicts. |
mark-i-m
force-pushed
the
markim_comments_0001
branch
from
c2a98c8
to
e2d558a
Compare
|
r? @jsseyfried |
|
r? @jseyfried |
src/libsyntax/ext/tt/macro_parser.rs
Outdated
| #[derive(Clone)] | ||
| enum TokenTreeOrTokenTreeVec { | ||
| Tt(TokenTree), | ||
| TtSeq(Vec<TokenTree>), | ||
| } | ||
|
|
||
| impl TokenTreeOrTokenTreeVec { | ||
| /// Returns the number of constituent token trees of `self`. |
There was a problem hiding this comment.
Maybe: constituent top level token trees.
|
Excellent, thanks! This is ancient code and IMO some of the most difficult in |
|
📌 Commit 2184400 has been approved by |
|
Lol, yes... git blame shows that most of it hasn't really been touched in years. It took me a couple of weeks to work through it 😛 |
…eyfried Run rustfmt and add doc comments to libsyntax/ext/tt/macro_parser.rs Similar to rust-lang#47603 cc @theotherphil since you reviewed my other PR 😄 And because they are already assigned on rust-lang#47603: r? @arielb1
Similar to #47603
cc @theotherphil since you reviewed my other PR 😄
And because they are already assigned on #47603:
r? @arielb1