-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run rustfmt and add doc comments to libsyntax/ext/tt/macro_parser.rs #47732
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
☔ The latest upstream changes (presumably #47748) made this pull request unmergeable. Please resolve the merge conflicts. |
c2a98c8
to
e2d558a
Compare
r? @jsseyfried |
r? @jseyfried |
src/libsyntax/ext/tt/macro_parser.rs
Outdated
#[derive(Clone)] | ||
enum TokenTreeOrTokenTreeVec { | ||
Tt(TokenTree), | ||
TtSeq(Vec<TokenTree>), | ||
} | ||
|
||
impl TokenTreeOrTokenTreeVec { | ||
/// Returns the number of constituent token trees of `self`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe: constituent top level token trees.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Excellent, thanks! This is ancient code and IMO some of the most difficult in |
📌 Commit 2184400 has been approved by |
Lol, yes... git blame shows that most of it hasn't really been touched in years. It took me a couple of weeks to work through it 😛 |
…eyfried Run rustfmt and add doc comments to libsyntax/ext/tt/macro_parser.rs Similar to rust-lang#47603 cc @theotherphil since you reviewed my other PR 😄 And because they are already assigned on rust-lang#47603: r? @arielb1
Similar to #47603
cc @theotherphil since you reviewed my other PR 😄
And because they are already assigned on #47603:
r? @arielb1