Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling s/casted/cast/ #48403

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Fix spelling s/casted/cast/ #48403

merged 1 commit into from
Mar 6, 2018

Conversation

lukaslueg
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 21, 2018
@GuillaumeGomez
Copy link
Member

I'll let an english native speaker instead.

r? @steveklabnik

@kennytm
Copy link
Member

kennytm commented Feb 25, 2018

Thanks for the PR @lukaslueg! There are several occurrences of "casted" not covered though (mainly src/libsyntax/parse/parser.rs, src/test/ui/issue-22644.stderr and issue-42954.stderr), could you change those too?

$ git grep -w casted
src/liballoc/btree/node.rs:105:/// `InternalNode` can be directly casted to a pointer to the underlying `LeafNode` portion of the
src/libcore/char.rs:82:/// Note that all [`char`]s are valid [`u32`]s, and can be casted to one with
src/libcore/char.rs:134:/// Note that all [`char`]s are valid [`u32`]s, and can be casted to one with
src/librustc_lint/types.rs:185:                                                             "only u8 can be casted into char");
src/libsyntax/parse/parser.rs:3099:                                            &format!("try {} the casted value", op_verb),
src/test/run-pass/extern-types-pointer-cast.rs:11:// Test that pointers to extern types can be casted from/to usize,
src/test/ui/cast_char.rs:15:    //~^ ERROR only u8 can be casted into char
src/test/ui/cast_char.rs:17:    //~^ ERROR only u8 can be casted into char
src/test/ui/cast_char.stderr:1:error: only u8 can be casted into char
src/test/ui/cast_char.stderr:13:error: only u8 can be casted into char
src/test/ui/issue-22644.stderr:8:   |                    help: try comparing the casted value: `(a as usize)`
src/test/ui/issue-22644.stderr:17:   |                      help: try comparing the casted value: `(a as usize)`
src/test/ui/issue-22644.stderr:26:   |                    help: try comparing the casted value: `(a as usize)`
src/test/ui/issue-22644.stderr:35:   |                      help: try comparing the casted value: `(a: usize)`
src/test/ui/issue-22644.stderr:44:   |                    help: try comparing the casted value: `(a: usize)`
src/test/ui/issue-22644.stderr:53:help: try comparing the casted value
src/test/ui/issue-22644.stderr:67:help: try comparing the casted value
src/test/ui/issue-22644.stderr:84:   |                    help: try shifting the casted value: `(a as usize)`
src/test/ui/issue-42954.stderr:8:   |         help: try comparing the casted value: `($i as u32)`

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2018
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018
@lukaslueg
Copy link
Contributor Author

I took liberty to force-push the additional changes

@pietroalbini pietroalbini added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2018
@pietroalbini
Copy link
Member

Ping from the release team @steveklabnik! This PR needs your review :)

@steveklabnik
Copy link
Member

This is very subtle, but is technically correct. People would understand either, generally, but I'm fine with changing it. Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 5, 2018

📌 Commit f7693c0 has been approved by steveklabnik

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 6, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
bors added a commit that referenced this pull request Mar 6, 2018
Rollup of 14 pull requests

- Successful merges: #48403, #48432, #48546, #48573, #48590, #48657, #48727, #48732, #48753, #48754, #48761, #48474, #48507, #47463
- Failed merges:
@alexcrichton alexcrichton merged commit f7693c0 into rust-lang:master Mar 6, 2018
@lukaslueg lukaslueg deleted the casted branch March 6, 2018 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants