Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clippy #48555

Closed
wants to merge 2 commits into from
Closed

Update clippy #48555

wants to merge 2 commits into from

Conversation

Manishearth
Copy link
Member

No description provided.

@Manishearth
Copy link
Member Author

r? @oli-obk

@bors delegate=oli-obk

@bors
Copy link
Contributor

bors commented Feb 26, 2018

✌️ @oli-obk can now approve this pull request

@oli-obk
Copy link
Contributor

oli-obk commented Feb 26, 2018

You need to update Cargo.lock

@Manishearth
Copy link
Member Author

Done

@kennytm
Copy link
Member

kennytm commented Feb 27, 2018

@bors r+ p=3

@bors
Copy link
Contributor

bors commented Feb 27, 2018

📌 Commit 689e7cf has been approved by kennytm

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 27, 2018
@kennytm
Copy link
Member

kennytm commented Feb 27, 2018

@bors r-

Note that #48450 (stabilize rotate_{left,right}) will be conflicting with this PR, since the clippy-mini-macro-test dependency compiletest_rs still uses the deprecated rotate() method (deleted in 48450).

compiletest_rs should be updated to use rotate_left.

[01:21:57] error[E0599]: no method named `rotate` found for type `&mut std::boxed::Box<[u8]>` in the current scope
[01:21:57]     --> /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.6/src/runtest.rs:2614:30
[01:21:57]      |
[01:21:57] 2614 |                         tail.rotate(data.len());
[01:21:57]      |                              ^^^^^^
[01:21:57] 
[01:21:57] error: aborting due to previous error
[01:21:57] 
[01:21:57] If you want more information on this error, try using "rustc --explain E0599"
[01:21:57] error: Could not compile `compiletest_rs`.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2018
@kennytm kennytm added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2018
@kennytm
Copy link
Member

kennytm commented Feb 27, 2018

Blocked by compiletest_rs 0.3.7 which should include Manishearth/compiletest-rs#102.

If anyone sees this still blocked during triage, please ping the crate author: Manishearth/compiletest-rs#102 (comment)

@kennytm
Copy link
Member

kennytm commented Mar 1, 2018

compiletest_rs 0.3.7 has been released, please update.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Mar 1, 2018
@pietroalbini
Copy link
Member

Ping from triage @Manishearth! This PR is not blocked anymore, and you need to update compiletest_rs as per #48555 (comment).

@Manishearth
Copy link
Member Author

I'll let someone else handle this, I'm on vacation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants