Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode/decode extern statics in metadata and incremental cache #49200

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Encode/decode extern statics in metadata and incremental cache #49200

merged 1 commit into from
Mar 21, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 20, 2018

fixes #49153

cc @abonander

r? @michaelwoerister incremental ICE

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 20, 2018
@michaelwoerister
Copy link
Member

Thanks, @oli-obk!

@bors r+ p=1 (fixes regression)

@bors
Copy link
Contributor

bors commented Mar 20, 2018

📌 Commit 13bfbe1 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018
@abonander
Copy link
Contributor

I've started the branch building to see if it's fixed the problem for me but I'm going straight to bed so I'll have results when I get up.

@bors
Copy link
Contributor

bors commented Mar 20, 2018

⌛ Testing commit 13bfbe1 with merge b405b3e7b2a49128a24cc50f7bb02c4129efd984...

@bors
Copy link
Contributor

bors commented Mar 20, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2018
@alexcrichton
Copy link
Member

@bors: retry

Weird travis deploy error:

/home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-s3-1.9.2/lib/dpl/provider/s3.rb:108:in `rescue in deploy': uninitialized constant Aws::S3::Errors (NameError)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018
@abonander
Copy link
Contributor

panic_unwind built successfully in stage1 but my laptop went to sleep before the compilation finished. We can probably call this one good though.

@kennytm
Copy link
Member

kennytm commented Mar 20, 2018

@bors p=11

@bors
Copy link
Contributor

bors commented Mar 21, 2018

⌛ Testing commit 13bfbe1 with merge c19264f...

bors added a commit that referenced this pull request Mar 21, 2018
@bors
Auto merge of #49200 - oli-obk:extern_static_metadata, r=michaelwoeri…
c19264f 
…ster

Encode/decode extern statics in metadata and incremental cache

fixes #49153

cc @abonander

r? @michaelwoerister incremental ICE
@bors
Copy link
Contributor

bors commented Mar 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing c19264f to master...

@bors bors merged commit 13bfbe1 into rust-lang:master Mar 21, 2018
@oli-obk oli-obk deleted the extern_static_metadata branch June 15, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE building panic_unwind (stage 1) in debug mode with incremental compilation
7 participants
@oli-obk @michaelwoerister @bors @abonander @alexcrichton @kennytm @rust-highfive