Fix DefKey lookup for proc-macro crates. #49273
Merged
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwoerister
added
the
beta-nominated
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit a1a3bf2 has been approved by |
bors
added
S-waiting-on-bors
nikomatsakis
added
the
beta-accepted
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2018
…cro-defkey, r=eddyb Fix DefKey lookup for proc-macro crates. Add a special case for proc-macro crates for `def_key()` in the metadata decoder (like we already have for many other methods in there). In the long run, it would be preferable to get rid of the need for special casing proc-macro crates (see rust-lang#49271). Fixes rust-lang#48739 (though I wasn't able to come up with a regression test, unfortunately) r? @eddyb
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 24, 2018
…cro-defkey, r=eddyb Fix DefKey lookup for proc-macro crates. Add a special case for proc-macro crates for `def_key()` in the metadata decoder (like we already have for many other methods in there). In the long run, it would be preferable to get rid of the need for special casing proc-macro crates (see rust-lang#49271). Fixes rust-lang#48739 (though I wasn't able to come up with a regression test, unfortunately) r? @eddyb
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 24, 2018
…cro-defkey, r=eddyb Fix DefKey lookup for proc-macro crates. Add a special case for proc-macro crates for `def_key()` in the metadata decoder (like we already have for many other methods in there). In the long run, it would be preferable to get rid of the need for special casing proc-macro crates (see rust-lang#49271). Fixes rust-lang#48739 (though I wasn't able to come up with a regression test, unfortunately) r? @eddyb
bors
added a commit
that referenced
this pull request
Mar 24, 2018
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a special case for proc-macro crates for
def_key()in the metadata decoder (like we already have for many other methods in there). In the long run, it would be preferable to get rid of the need for special casing proc-macro crates (see #49271).Fixes #48739 (though I wasn't able to come up with a regression test, unfortunately)
r? @eddyb