Work around LLVM debuginfo problem in librustc_driver. #49904

michaelwoerister · 2018-04-12T13:17:41Z

Works around a problem (#48910) with global variable debuginfo generation for rustc_driver::get_trans::LOAD by applying #[no_debug] to it (which just disables debuginfo generation for that variable). This way we can build the compiler with debuginfo again.

Since the problem is also present in beta, this workaround might have to be backported.

r? @alexcrichton

alexcrichton · 2018-04-12T14:00:28Z

@bors: r+

bors · 2018-04-12T14:00:29Z

📌 Commit f1610ae has been approved by alexcrichton

@alexcrichton

…lexcrichton Work around LLVM debuginfo problem in librustc_driver. Works around a problem (rust-lang#48910) with global variable debuginfo generation for `rustc_driver::get_trans::LOAD` by applying `#[no_debug]` to it (which just disables debuginfo generation for that variable). This way we can build the compiler with debuginfo again. Since the problem is also present in beta, this workaround might have to be backported. r? @alexcrichton

kennytm · 2018-04-14T16:18:17Z

Yesterday the rollup 49939 failed on dist-arm-linux due to a strange error when cross-compiling liballoc (stage1, x86_64-unknown-linux-gnu → arm-unknown-linux-gnueabi):

[00:22:41] error: failed to prepare thin LTO module: Invalid function metadata: outgoing forward refs (Producer: 'LLVM6.0.0' Reader: 'LLVM 6.0.0')

At that point, the PRs involved in the rollup are {"#49289", "#49396", "#49850", "#49866", "#49876", "#49884", "#49886", "#49904", "#49908", "#49915", "#49916", "#49922"}

Later I've reconstructed the rollup by removing all liballoc or metadata-related PRs, and the final list is {"#49465", "#49852", "#49864", "#49866", "#49871", "#49876", "#49886", "#49908", "#49913", "#49915", "#49916", "#49922", "#49951", "#49958"}

The difference, that may be the cause of that error, is:

- #49904 (Work around LLVM debuginfo problem in librustc_driver.)
- #49396 (Make OnDiskCache thread-safer)
- #49289 (Make --emit=metadata output metadata regardless of link)
- #49884 (core: Remove panics from some `Layout` methods)
- #49850 (core: Inline `From<AllocErr> for CollectionAllocErr`)

Here, 49396 and 49289 are already merged, which leaves only 49904, 49884 and 49850 as suspects. Out of which, I think this PR is the strongest candidate since it touches LLVM. @michaelwoerister could you verify if cross-compiling libstd to ARM works fine?

bors · 2018-04-15T17:50:20Z

⌛ Testing commit f1610ae with merge 9e85294de5f524b40b7e56327dbbf765ca29cb24...

bors · 2018-04-15T18:16:18Z

💔 Test failed - status-travis

rust-highfive · 2018-04-15T18:16:20Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:23:36] error: failed to prepare thin LTO module: Invalid function metadata: outgoing forward refs (Producer: 'LLVM6.0.0' Reader: 'LLVM 6.0.0')
[00:23:36]
[00:23:36] error: aborting due to previous error
[00:23:36]
[00:23:36] [RUSTC-TIMING] alloc test:false 6.701
[00:23:36] error: Could not compile `alloc`.
[00:23:36]
[00:23:36] Caused by:
[00:23:36]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name alloc liballoc/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,link -C opt-level=2 -C metadata=f44c2b79c5c900d2 -C extra-filename=-f44c2b79c5c900d2 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/aarch64-unknown-linux-gnu/release/deps --target aarch64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/aarch64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/aarch64-unknown-linux-gnu/release/deps/libcompiler_builtins-0131a1f921771d4b.rlib --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/aarch64-unknown-linux-gnu/release/deps/libcore-e89ee5bd779a4348.rlib -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/aarch64-unknown-linux-gnu/release/build/compiler_builtins-dd154bc0b1d5dfeb/out` (exit code: 101)
[00:23:36] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "aarch64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:23:36] expected success, got: exit code: 101
[00:23:36] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1085:9
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:242aa404:start=1523816141901628648,finish=1523816141909396600,duration=7767952
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:06b16048
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:06b16048:start=1523816141916492114,finish=1523816141924556659,duration=8064545
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0374002e
$ dmesg | grep -i kill
[   10.476510] init: failsafe main process (1094) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-04-15T18:16:24Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:23:36] error: failed to prepare thin LTO module: Invalid function metadata: outgoing forward refs (Producer: 'LLVM6.0.0' Reader: 'LLVM 6.0.0')
[00:23:36]
[00:23:36] error: aborting due to previous error
[00:23:36]
[00:23:36] [RUSTC-TIMING] alloc test:false 6.701
[00:23:36] error: Could not compile `alloc`.
[00:23:36]
[00:23:36] Caused by:
[00:23:36]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name alloc liballoc/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,link -C opt-level=2 -C metadata=f44c2b79c5c900d2 -C extra-filename=-f44c2b79c5c900d2 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/aarch64-unknown-linux-gnu/release/deps --target aarch64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/aarch64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/aarch64-unknown-linux-gnu/release/deps/libcompiler_builtins-0131a1f921771d4b.rlib --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/aarch64-unknown-linux-gnu/release/deps/libcore-e89ee5bd779a4348.rlib -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/aarch64-unknown-linux-gnu/release/build/compiler_builtins-dd154bc0b1d5dfeb/out` (exit code: 101)
[00:23:36] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "aarch64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:23:36] expected success, got: exit code: 101
[00:23:36] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1085:9
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:242aa404:start=1523816141901628648,finish=1523816141909396600,duration=7767952
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:06b16048
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:06b16048:start=1523816141916492114,finish=1523816141924556659,duration=8064545
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0374002e
$ dmesg | grep -i kill
[   10.476510] init: failsafe main process (1094) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

michaelwoerister · 2018-04-16T08:24:00Z

I'll take a look. It might also be a different issue introduced by having a bootstrap compiler that now that uses LLVM 6.0?

kennytm · 2018-04-16T09:23:03Z

The error happens when cross-compiling using the stage1 compiler, so I doubt this is caused by the bootstrap (stage0) compiler.

Though LLVM 6 can be the cause, since the smoke test CI uses LLVM 3.9. This problem might also be ARM-specific.

alexcrichton · 2018-04-16T14:20:28Z

FWIW the most recent failure on CI was cross-compiling libstd in stage1 to aarch64-unknown-linux-gnu, which may point it more as a cross-compile thing rather than an ARM thing, but I'd also imagine that the ARM and aarch64 backends probably share a good deal of code.

nnethercote · 2018-04-17T00:17:33Z

I'm still getting the clang abort when compiling with debuginfo on Linux64.

…ans::LOAD.

michaelwoerister · 2018-04-17T16:28:05Z

I was able to reproduce the error and this version doesn't trigger it anymore.

@bors r=alexcrichton

bors · 2018-04-17T16:28:06Z

📌 Commit 2814928 has been approved by alexcrichton

bors · 2018-04-17T19:26:33Z

⌛ Testing commit 2814928 with merge 786e305...

@alexcrichton

Work around LLVM debuginfo problem in librustc_driver. Works around a problem (#48910) with global variable debuginfo generation for `rustc_driver::get_trans::LOAD` by applying `#[no_debug]` to it (which just disables debuginfo generation for that variable). This way we can build the compiler with debuginfo again. Since the problem is also present in beta, this workaround might have to be backported. r? @alexcrichton

bors · 2018-04-17T21:56:47Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 786e305 to master...

… r=alexcrichton Backport of rust-lang#49904 See rust-lang#49904.

[beta] backport various PRs original PRs: * #49949 (not yet merged at the time of writing) * #49947 (long running const eval error -> warning) * #49833 (static recursion) * #49876 (no clippy in stable rls) * #49904 (Work around LLVM debuginfo problem in librustc_driver. )

alexcrichton · 2018-04-19T23:59:33Z

@michaelwoerister I'm getting that same error on https://travis-ci.org/rust-lang-nursery/stdsimd/jobs/368892648, what'd you end up needing to do to fix it?

michaelwoerister · 2018-04-20T08:23:20Z

In my case it was that we were not producing debuginfo for drop-glue and shims anymore. Then I changed the last commit (2814928) and the error went away.

nnethercote · 2018-04-25T10:08:42Z

@michaelwoerister: I just updated and I'm still seeing this error :(

michaelwoerister · 2018-04-25T10:30:13Z

@nnethercote The fix merged into the current beta branch. @rust-lang/release, is the bootstrapping compiler always an up-to-date beta?

nnethercote · 2018-04-25T10:36:49Z

Aha! That would explain it. My stage0 compiler is "1.26.0-beta.1 (18aaa1d 2018-04-03)", which is too old to have this fix.

alexcrichton · 2018-04-25T13:40:51Z

Ah yes the bootstrap compiler does not automatically update, but a PR is more than welcome to tweak src/stage0.txt!

michaelwoerister · 2018-04-25T13:59:03Z

@alexcrichton, your wish is my command: #50222

rust-highfive assigned alexcrichton Apr 12, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2018

alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Apr 12, 2018

kennytm mentioned this pull request Apr 13, 2018

Rollup of 11 pull requests #49924

Closed

kennytm mentioned this pull request Apr 13, 2018

Rollup of 14 pull requests #49939

Merged

kennytm mentioned this pull request Apr 14, 2018

core: Inline From<AllocErr> for CollectionAllocErr #49850

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 15, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2018

michaelwoerister added 4 commits April 17, 2018 15:01

Add #[no_debug] to trans_fn_attrs() query.

d5b48a4

Support #[no_debug] for global variables.

5cc7d5e

Use #[no_debug] to work around LLVM problem with rustc_driver::get_tr…

6f9c36e

…ans::LOAD.

Clean up attribute handling in create_function_debug_context().

2814928

michaelwoerister force-pushed the no-debug-attr branch from f1610ae to 2814928 Compare April 17, 2018 14:23

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 17, 2018

bors merged commit 2814928 into rust-lang:master Apr 17, 2018

michaelwoerister mentioned this pull request Apr 18, 2018

Backport of #49904 #50046

Merged

alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 19, 2018

kennytm added a commit to oli-obk/rust that referenced this pull request Apr 19, 2018

Rollup merge of rust-lang#50046 - michaelwoerister:backport-no-debug,…

0f4bb2f

… r=alexcrichton Backport of rust-lang#49904 See rust-lang#49904.

oli-obk mentioned this pull request Apr 19, 2018

[beta] backport various PRs #50027

Merged

alexcrichton mentioned this pull request Apr 20, 2018

fix errors/warnings from the stabilization of cfg_target_feature and target_feature rust-lang/stdarch#432

Merged

pnkfelix mentioned this pull request Dec 3, 2018

NLL error on closure, but not on equivalent function #55526

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Work around LLVM debuginfo problem in librustc_driver. #49904

Work around LLVM debuginfo problem in librustc_driver. #49904

michaelwoerister commented Apr 12, 2018

alexcrichton commented Apr 12, 2018

bors commented Apr 12, 2018

kennytm commented Apr 14, 2018

bors commented Apr 15, 2018

bors commented Apr 15, 2018

rust-highfive commented Apr 15, 2018

rust-highfive commented Apr 15, 2018

michaelwoerister commented Apr 16, 2018

kennytm commented Apr 16, 2018

alexcrichton commented Apr 16, 2018

nnethercote commented Apr 17, 2018

michaelwoerister commented Apr 17, 2018

bors commented Apr 17, 2018

bors commented Apr 17, 2018

bors commented Apr 17, 2018

alexcrichton commented Apr 19, 2018

michaelwoerister commented Apr 20, 2018

nnethercote commented Apr 25, 2018

michaelwoerister commented Apr 25, 2018

nnethercote commented Apr 25, 2018

alexcrichton commented Apr 25, 2018

michaelwoerister commented Apr 25, 2018

Work around LLVM debuginfo problem in librustc_driver. #49904

Work around LLVM debuginfo problem in librustc_driver. #49904

Conversation

michaelwoerister commented Apr 12, 2018

alexcrichton commented Apr 12, 2018

bors commented Apr 12, 2018

kennytm commented Apr 14, 2018

bors commented Apr 15, 2018

bors commented Apr 15, 2018

rust-highfive commented Apr 15, 2018

rust-highfive commented Apr 15, 2018

michaelwoerister commented Apr 16, 2018

kennytm commented Apr 16, 2018

alexcrichton commented Apr 16, 2018

nnethercote commented Apr 17, 2018

michaelwoerister commented Apr 17, 2018

bors commented Apr 17, 2018

bors commented Apr 17, 2018

bors commented Apr 17, 2018

alexcrichton commented Apr 19, 2018

michaelwoerister commented Apr 20, 2018

nnethercote commented Apr 25, 2018

michaelwoerister commented Apr 25, 2018

nnethercote commented Apr 25, 2018

alexcrichton commented Apr 25, 2018

michaelwoerister commented Apr 25, 2018