Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #49924

Closed
wants to merge 30 commits into from
Closed

Rollup of 11 pull requests #49924

wants to merge 30 commits into from

Commits on Mar 22, 2018

  1. Configuration menu
    Copy the full SHA
    2a5f3ee View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2018

  1. Configuration menu
    Copy the full SHA
    8056506 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2018

  1. Reformat trans skip condition

    varkor committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    7575d96 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7d93920 View commit details
    Browse the repository at this point in the history
  3. Improve function name.

    fanzier committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    0bf3eb6 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2018

  1. Rebase and update code.

    fanzier committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    7e50039 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34956c8 View commit details
    Browse the repository at this point in the history
  3. Ignore copyright year when generating deriving span tests

    Previously, generate-deriving-span-tests.py would regenerate all the tests anew, even if they hadn't changed. This creates unnecessary diffs that only change the copyright year. Now we check to see if any of the content of the test has changed before generating the new one.
    varkor committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    0b393e0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2ef8493 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2018

  1. core: Remove panics from some Layout methods

    `Layout` is often used at the core of allocation APIs and is as a result pretty
    sensitive to codegen in various circumstances. I was profiling `-C opt-level=z`
    with a wasm project recently and noticed that the `unwrap()` wasn't removed
    inside of `Layout`, causing the program to be much larger than it otherwise
    would be. If inlining were more aggressive LLVM would have figured out that the
    panic could be eliminated, but in general the methods here can't panic in the
    first place!
    
    As a result this commit makes the following tweaks:
    
    * Removes `unwrap()` and replaces it with `unsafe` in `Layout::new` and
      `Layout::for_value`. For posterity though a debug assertion was left behind.
    * Removes an `unwrap()` in favor of `?` in the `repeat` method. The comment
      indicating that the function call couldn't panic wasn't quite right in that if
      `alloc_size` becomes too large and if `align` is high enough it could indeed
      cause a panic.
    
    This'll hopefully mean that panics never get introduced into code in the first
    place, ensuring that `opt-level=z` is closer to `opt-level=s` in this regard.
    alexcrichton committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    ec3bccb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d554f4c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f78b8c0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f711c05 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f1610ae View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6f10146 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    de34533 View commit details
    Browse the repository at this point in the history
  8. Make OnDiskCache thread-safer

    Zoxc committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    807c1a0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2f60341 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2018

  1. Remove -Z miri debugging option

    f-bro committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    35087fc View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#49396 - Zoxc:sync-on-disk-cache, r=michaelw…

    …oerister
    
    Make OnDiskCache thread-safer
    
    I'm not sure if `synthetic_expansion_infos` is handled correctly.
    
    `interpret_alloc_cache` and `interpret_alloc_size` seems to be wrong though, since the code may now decode two `AllocId`s in parallel. I'd like some input on how to fix that.
    
    cc @oli-obk
    
    r? @michaelwoerister
    kennytm committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    976a17b View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#49626 - fanzier:chalk-lowering, r=scalexm

    Implement Chalk lowering rule Normalize-From-Impl
    
    This extends the Chalk lowering pass with the "Normalize-From-Impl" rule for generating program clauses from a trait definition as part of rust-lang#49177.
    
    r? @nikomatsakis
    kennytm committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    509ccd6 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#49866 - Mark-Simulacrum:pr-travis-windows, …

    …r=alexcrichton
    
    Cross-compile builder to Windows for PRs on Travis
    
    I chose a completely arbitrary windows target here (I have no idea what's best, we could do multiple -- they are relatively fast).
    
    r? @alexcrichton
    kennytm committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    f4ac852 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#49876 - oli-obk:no_secret_clippy_on_stable_…

    …☹, r=nrc
    
    Don't inject clippy into rls on stable/beta
    
    r? @nrc
    
    as discussed at the all-hands
    kennytm committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    9dbfcb5 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#49884 - alexcrichton:less-unwrap, r=Mark-Si…

    …mulacrum
    
    core: Remove panics from some `Layout` methods
    
    `Layout` is often used at the core of allocation APIs and is as a result pretty
    sensitive to codegen in various circumstances. I was profiling `-C opt-level=z`
    with a wasm project recently and noticed that the `unwrap()` wasn't removed
    inside of `Layout`, causing the program to be much larger than it otherwise
    would be. If inlining were more aggressive LLVM would have figured out that the
    panic could be eliminated, but in general the methods here can't panic in the
    first place!
    
    As a result this commit makes the following tweaks:
    
    * Removes `unwrap()` and replaces it with `unsafe` in `Layout::new` and
      `Layout::for_value`. For posterity though a debug assertion was left behind.
    * Removes an `unwrap()` in favor of `?` in the `repeat` method. The comment
      indicating that the function call couldn't panic wasn't quite right in that if
      `alloc_size` becomes too large and if `align` is high enough it could indeed
      cause a panic.
    
    This'll hopefully mean that panics never get introduced into code in the first
    place, ensuring that `opt-level=z` is closer to `opt-level=s` in this regard.
    kennytm committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    09c321c View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#49886 - varkor:generate-deriving-span-tests…

    …-usability, r=nikomatsakis
    
    Ignore copyright year when generating deriving span tests
    
    Previously, generate-deriving-span-tests.py would regenerate all the tests anew, even if they hadn't changed. This creates unnecessary diffs that only change the copyright year. Now we check to see if any of the content of the test has changed before generating the new one.
    kennytm committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    28bf5a3 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#49904 - michaelwoerister:no-debug-attr, r=a…

    …lexcrichton
    
    Work around LLVM debuginfo problem in librustc_driver.
    
    Works around a problem (rust-lang#48910) with global variable debuginfo generation for `rustc_driver::get_trans::LOAD` by applying `#[no_debug]` to it (which just disables debuginfo generation for that variable). This way we can build the compiler with debuginfo again.
    
    Since the problem is also present in beta, this workaround might have to be backported.
    
    r? @alexcrichton
    kennytm committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    451cf7c View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#49908 - chrisccoulson:fix-rustdoc-themes-te…

    …st-without-rpath, r=Mark-Simulacrum
    
    Fix test failure in src/tools/rustdoc-themes when rust.rpath = false
    
    See rust-lang#49907
    kennytm committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    0bf5af0 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#49922 - f-bro:zmiri, r=oli-obk

    Remove -Zmiri debugging option
    
    ?r @oli-obk
    kennytm committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    5d59264 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#49916 - llogiq:doc-atomic-fetch-update, r=k…

    …ennytm
    
    improve Atomic*::fetch_update docs
    
    This clarifies that fetch_update *always* returns the previous value, either as `Ok(_)` or `Err(_)`, depending on whether the supplied update function returned `Some(_)` or `None`.
    kennytm committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    ba8be1d View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#49289 - varkor:emit-metadata-without-link, …

    …r=michaelwoerister
    
    Make --emit=metadata output metadata regardless of link
    
    Fixes rust-lang#40109. I'm not sure whether this condition was important here or not, but I can't see why it is required (removing it doesn't cause the error the comment warns about, so I'm assuming it's safe). If this is too heavy-handed, I can special-case on `OutputType::Metadata`.
    kennytm committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    f1da9f4 View commit details
    Browse the repository at this point in the history