Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Read::chars and char::decode_utf8 #49970

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Deprecate Read::chars and char::decode_utf8 #49970

merged 1 commit into from
Apr 24, 2018

Conversation

SimonSapin
Copy link
Contributor

@SimonSapin SimonSapin added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 14, 2018
@SimonSapin
Copy link
Contributor Author

r? @sfackler

@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:00:51] configure: rust.quiet-tests     := True
---
[00:20:45] error: use of deprecated item 'io::CharsError::Other::0': Use str::from_utf8 instead:
[00:20:45]     https://doc.rust-lang.org/nightly/std/str/struct.Utf8Error.html#examples
[00:20:45]     --> libstd/io/mod.rs:2037:11
[00:20:45]      |
[00:20:45] 2037 |     Other(Error),
[00:20:45]      |           ^^^^^^
[00:20:45]      |
[00:20:45]      = note: `-D deprecated` implied by `-D warnings`
---
[00:20:47]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name std libstd/lib.rs --color always --error-format json --crate-type dylib --crate-type rlib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 --cfg feature="alloc_jemalloc" --cfg feature="backtrace" --cfg feature="jemalloc" --cfg feature="panic-unwind" --cfg feature="panic_unwind" -C metadata=59f1365839a15336 -C extra-filename=-59f1365839a15336 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liblibc-22a7664bd150c80d.rlib --extern rustc_lsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_lsan-dc103db2cc707fb1.rlib --extern alloc_system=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc_system-a7af859ebb7ffd34.rlib --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_unwind-0d5ca310002751eb.rlib --extern alloc_jemalloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc_jemalloc-2f9a4f2e814ed058.rlib --extern rustc_tsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_tsan-ee8ce53bd96ab14e.rlib --extern rustc_msan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_msan-cd51e4d8e5ddddce.rlib --extern std_unicode=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libstd_unicode-f0c30809ac048014.rlib --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-d4e2de02cb1be3d7.rlib --extern rustc_asan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_asan-9ca7a6a39fc271b4.rlib --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libunwind-2c193ad75e997618.rlib --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcore-64878136ec7adadb.rlib --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc-a1af8df7cb7f6288.rlib --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_abort-ae9922ea98a7d2f5.rlib -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/native/libbacktrace/.libs -l static=backtrace -l dl -l rt -l pthread -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/build/compile/rustlib/x86_64-unknown-linux-gnu
---
121760 ./obj/build/bootstrap/debug/incremental/bootstrap-351vorei3hhuv/s-f04dtyyciv-n1ddi7-3ssff2uugm5rt
---
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:00758524:start=1523744036964293721,finish=1523744036971887334,duration=7593613
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:059a5924
$ dmesg | grep -i kill
[   10.306026] init: failsafe main process (1093) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2018
@sfackler
Copy link
Member

@bors r+

@nagisa
Copy link
Member

nagisa commented Apr 23, 2018

@bors r=sfackler

@pietroalbini
Copy link
Member

@bors are you still there?

@alexcrichton alexcrichton reopened this Apr 23, 2018
@alexcrichton
Copy link
Member

@bors: r=sfackler

@bors
Copy link
Contributor

bors commented Apr 23, 2018

📌 Commit 7cbeddb has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2018
@aturon
Copy link
Member

aturon commented Apr 23, 2018

@bors: rollup

kennytm added a commit to kennytm/rust that referenced this pull request Apr 24, 2018
@kennytm
Rollup merge of rust-lang#49970 - SimonSapin:deprecate, r=sfackler
6b1ed8e 
Deprecate Read::chars and char::decode_utf8

Per FCP:

* rust-lang#27802 (comment)
* rust-lang#33906 (comment)
@kennytm kennytm mentioned this pull request Apr 24, 2018
Merged
bors added a commit that referenced this pull request Apr 24, 2018
@bors
Auto merge of #50191 - kennytm:rollup, r=kennytm
52ed3d8 
Rollup of 11 pull requests

Successful merges:

 - #49461 (std: Child::kill() returns error if process has already exited)
 - #49727 (Add Cell::update)
 - #49812 (Fix revision support for UI tests.)
 - #49829 (Add doc links to `std::os` extension traits)
 - #49906 (Stabilize `std::hint::unreachable_unchecked`.)
 - #49970 (Deprecate Read::chars and char::decode_utf8)
 - #49985 (don't see issue #0)
 - #50118 (fix search bar bug)
 - #50139 (encourage descriptive issue titles)
 - #50174 (Use FxHashMap in syntax_pos::symbol::Interner::intern.)
 - #50185 (core: Fix overflow in `int::mod_euc` when `self < 0 && rhs == MIN`)

Failed merges:
@bors bors merged commit 7cbeddb into rust-lang:master Apr 24, 2018
This was referenced Apr 24, 2018
Closed
Closed
@SimonSapin SimonSapin deleted the deprecate branch May 16, 2018 15:46
@Lucretiel Lucretiel mentioned this pull request Nov 30, 2018
Merged
@hkratz hkratz mentioned this pull request Nov 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@SimonSapin @rust-highfive @sfackler @nagisa @pietroalbini @alexcrichton @bors @aturon @kennytm