Revert "Implement FromStr for PathBuf" #50401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 05a9acc.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
alexcrichton
added
beta-nominated
|
r? @sfackler |
|
@bors r+ |
|
📌 Commit f684147 has been approved by |
bors
added
the
S-waiting-on-bors
alexcrichton
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
May 3, 2018
[beta] Revert "Implement FromStr for PathBuf" This is a backport of #50401
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
May 3, 2018
…r=sfackler Revert "Implement FromStr for PathBuf" This reverts commit 05a9acc. The libs team was discussing rust-lang#44431 today and the changes originally added in rust-lang#48292 and the conclusion was that we'd like to revert this for now until `!` is stable. This'll provide us maximal flexibility to tweak the error type here in the future, and it looks like `!` is close-ish to stabilization so hopefully this won't be delayed for too long.
bors
added a commit
that referenced
this pull request
May 3, 2018
Rollup of 12 pull requests Successful merges: - #50302 (Add query search order check) - #50320 (Fix invalid path generation in rustdoc search) - #50349 (Rename "show type declaration" to "show declaration") - #50360 (Clarify wordings of the `unstable_name_collision` lint.) - #50365 (Use two vectors in nearest_common_ancestor.) - #50393 (Allow unaligned reads in constants) - #50401 (Revert "Implement FromStr for PathBuf") - #50406 (Forbid constructing empty identifiers from concat_idents) - #50407 (Always inline simple BytePos and CharPos methods.) - #50416 (check if the token is a lifetime before parsing) - #50417 (Update Cargo) - #50421 (Fix ICE when using a..=b in a closure.) Failed merges:
SimonSapin
added a commit
to SimonSapin/rust
that referenced
this pull request
Oct 17, 2018
Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Oct 27, 2018
Implement FromStr for PathBuf Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 28, 2018
Implement FromStr for PathBuf Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)
ischeinkman
pushed a commit
to ischeinkman/libnx-rs-std
that referenced
this pull request
Dec 20, 2018
Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 05a9acc.
The libs team was discussing #44431 today and the changes originally added in #48292 and the conclusion was that we'd like to revert this for now until
!is stable. This'll provide us maximal flexibility to tweak the error type here in the future, and it looks like!is close-ish to stabilization so hopefully this won't be delayed for too long.