Skip to content

Conversation

GuillaumeGomez
Copy link
Member

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2018
@QuietMisdreavus
Copy link
Contributor

@bors r+ rollup

I just noticed we don't mention the rustdoc-ui or rustdoc-js tests in https://rust-lang-nursery.github.io/rustc-guide/tests/intro.html at all. I've opened an issue there (rust-lang/rustc-dev-guide#120) as a note-to-self to make sure those get documented.

@bors
Copy link
Collaborator

bors commented May 2, 2018

📌 Commit 00bbda1 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2018
@QuietMisdreavus
Copy link
Contributor

Another note while i'm sitting on this tab: It strikes me as unfortunate that the rustdoc-js tests need to parse their header commands totally separately from everything else. Since they run through node i don't think it'll be easy to hook into compiletest's command parsing, but it's still unfortunate.

kennytm added a commit to kennytm/rust that referenced this pull request May 3, 2018
…er-check, r=QuietMisdreavus

Add query search order check

Fixes rust-lang#50180.

r? @QuietMisdreavus
bors added a commit that referenced this pull request May 3, 2018
Rollup of 12 pull requests

Successful merges:

 - #50302 (Add query search order check)
 - #50320 (Fix invalid path generation in rustdoc search)
 - #50349 (Rename "show type declaration" to "show declaration")
 - #50360 (Clarify wordings of the `unstable_name_collision` lint.)
 - #50365 (Use two vectors in nearest_common_ancestor.)
 - #50393 (Allow unaligned reads in constants)
 - #50401 (Revert "Implement FromStr for PathBuf")
 - #50406 (Forbid constructing empty identifiers from concat_idents)
 - #50407 (Always inline simple BytePos and CharPos methods.)
 - #50416 (check if the token is a lifetime before parsing)
 - #50417 (Update Cargo)
 - #50421 (Fix ICE when using a..=b in a closure.)

Failed merges:
@bors bors merged commit 00bbda1 into rust-lang:master May 3, 2018
@GuillaumeGomez GuillaumeGomez deleted the add-query-search-order-check branch May 4, 2018 11:27
bors added a commit that referenced this pull request May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants