Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CI job that makes sure rustc builds with parallel queries enabled. #50444

Merged
merged 1 commit into from
May 5, 2018
Merged

Add a CI job that makes sure rustc builds with parallel queries enabled. #50444

merged 1 commit into from
May 5, 2018

Conversation

michaelwoerister
Copy link
Member

This shouldn't take up too much CI time :)

cc #48607
cc @Zoxc

r? @alexcrichton

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2018
@michaelwoerister
Copy link
Member Author

Of course anybody from @rust-lang/infra can review too!

@michaelwoerister michaelwoerister mentioned this pull request May 4, 2018
Closed
@alexcrichton
Copy link
Member

@michaelwoerister it looks like the primary change here is also enabling checking this on MinGW on the check builder, but just wanted to confirm that's expected. I think we're already running checks for parallel queries on CI, right?

@michaelwoerister
Copy link
Member Author

Yes, the x86_64-gnu-debug job does that too (which I only found out after @Zoxc made me aware of it :)). This PR adds to the check to the mingw-check job so it's tested for PRs too. If we go ahead with this, we might want to consider renaming mingw-check to something like mingw-crossbuild-and-parallel-queries-check to make things clearer.

@alexcrichton
Copy link
Member

@bors: r+

Ok cool just making sure!

@bors
Copy link
Contributor

bors commented May 4, 2018

📌 Commit 58eeeb4 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 4, 2018
@kennytm
Rollup merge of rust-lang#50444 - michaelwoerister:check-parallel-que…
c5b5802 
…ries-in-ci, r=alexcrichton

Add a CI job that makes sure rustc builds with parallel queries enabled.

This shouldn't take up too much CI time `:)`

cc rust-lang#48607
cc @Zoxc

r? @alexcrichton
@kennytm kennytm mentioned this pull request May 4, 2018
Closed
@bors
Copy link
Contributor

bors commented May 5, 2018

⌛ Testing commit 58eeeb4 with merge f9bfe84...

bors added a commit that referenced this pull request May 5, 2018
@bors
Auto merge of #50444 - michaelwoerister:check-parallel-queries-in-ci,…
f9bfe84 
… r=alexcrichton

Add a CI job that makes sure rustc builds with parallel queries enabled.

This shouldn't take up too much CI time `:)`

cc #48607
cc @Zoxc

r? @alexcrichton
@bors
Copy link
Contributor

bors commented May 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing f9bfe84 to master...

@bors bors merged commit 58eeeb4 into rust-lang:master May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelwoerister @alexcrichton @bors @rust-highfive