Ensure every unstable language feature has a tracking issue. #51090
+67
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
kennytm
changed the title
This comment has been minimized.
This comment has been minimized.
kennytm
force-pushed
the
tidy-check-missing-tracking-issue
branch
from
1bfbf30
to
141399b
Compare
This comment has been minimized.
This comment has been minimized.
kennytm
force-pushed
the
tidy-check-missing-tracking-issue
branch
from
141399b
to
79e53a3
Compare
|
@bors: r+ |
|
📌 Commit 79e53a3 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 79e53a3377be86de3177d509d64352b77c717367 with merge 5b01b21079590ee4130e9d797d5b974eb4b595c8... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
kennytm
force-pushed
the
tidy-check-missing-tracking-issue
branch
from
79e53a3
to
509f414
Compare
|
@bors r=alexcrichton |
|
📌 Commit 509f414 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 27, 2018
…lexcrichton Ensure every unstable language feature has a tracking issue. Filled in the missing numbers: * `abi_ptx` → #38788 * `generators` → #43122 * `global_allocator` → #27389 Reused existing tracking issues because they were decomposed from a larger feature * `*_target_feature` → #44839 (reusing the old `target_feature` number) * `proc_macros_*` → #38356 (reusing the to-be-stabilized `proc_macros` number) Filed new issues * `exhaustive_patterns` → #51085 * `pattern_parentheses` → #51087 * `wasm_custom_section` and `wasm_import_module` → #51088
|
☀️ Test successful - status-appveyor, status-travis |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 6, 2023
…compiler-errors Issue numbers are enforced on active features; remove FIXME Since rust-lang#51090 tidy enforces that active features have an issue number, so remove the FIXME. This PR is part of rust-lang#44366 which is E-help-wanted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filled in the missing numbers:
abi_ptx→ Tracking issue for the "ptx-kernel" ABI #38788generators→ Tracking issue for RFC 2033: Experimentally add coroutines to Rust #43122global_allocator→ Tracking issue for changing the global, default allocator (RFC 1974) #27389Reused existing tracking issues because they were decomposed from a larger feature
*_target_feature→ Tracking issue for RFC 2045: improving#[target_feature]#44839 (reusing the oldtarget_featurenumber)proc_macros_*→ Tracking issue for RFC 1566: Procedural macros #38356 (reusing the to-be-stabilizedproc_macrosnumber)Filed new issues
exhaustive_patterns→ Tracking issue for RFC 1872:exhaustive_patternsfeature #51085pattern_parentheses→ Tracking issue for RFC 554:pattern_parenthesesfeature #51087wasm_custom_sectionandwasm_import_module→ Tracking issue for the #[wasm_custom_section] attribute #51088