test: Ignore some problematic tests on sparc and sparc64 #51343

glaubitz · 2018-06-04T11:33:11Z

This updates the list of tests which can be safely ignored on sparc and sparc64.

rust-highfive · 2018-06-04T11:33:14Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2018-06-04T12:25:21Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:start:test_ui
Check compiletest suite=ui mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:49:27] 
[00:49:27] running 1486 tests
[00:49:31] ...........F...............................................................................i........
[00:49:42] ....................................................................................................
[00:49:45] ....................................................................................................
[00:49:49] ....................................................................................................
[00:49:52] ....................................................................................................
---
[00:50:20] ...........................................................................i........................
[00:50:25] ....................................................................................................
[00:50:32] ....................................................................................................
[00:50:38] ....................................................................................................
[00:50:43] ........iF................iiiiiiiii...................................................
[00:50:43] 
[00:50:43] ---- [ui] ui/asm-out-assign-imm.rs stdout ----
[00:50:43] diff of stderr:
[00:50:43] 
[00:50:43] 
[00:50:43] 1 error[E0384]: cannot assign twice to immutable variable `x`
[00:50:43] -   --> $DIR/asm-out-assign-imm.rs:30:9
[00:50:43] +   --> $DIR/asm-out-assign-imm.rs:31:9
[00:50:43] 3    |
[00:50:43] 4 LL |     x = 1;
[00:50:43] 5    |     ----- first assignment to `x`
[00:50:43] 
[00:50:43] The actual stderr differed from the expected stderr.
[00:50:43] The actual stderr differed from the expected stderr.
[00:50:43] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm-out-assign-imm/asm-out-assign-imm.stderr
[00:50:43] To update references, rerun the tests and pass the `--bless` flag
[00:50:43] To only update this specific test, also pass `--test-args asm-out-assign-imm.rs`
[00:50:43] error: 1 errors occurred comparing output.
[00:50:43] status: exit code: 101
[00:50:43] status: exit code: 101
[00:50:43] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/asm-out-assign-imm.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm-out-assign-imm/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm-out-assign-imm/auxiliary" "-A" "unused"
[00:50:43] ------------------------------------------
[00:50:43] 
[00:50:43] ------------------------------------------
[00:50:43] stderr:
[00:50:43] stderr:
[00:50:43] ------------------------------------------
[00:50:43] {"message":"cannot assign twice to immutable variable `x`","code":{"code":"E0384","explanation":"\nThis error occurs when an attempt is made to reassign an immutable variable.\nFor example:\n\n```compile_fail,E0384\nfn main() {\n    let x = 3;\n    x = 5; // error, reassignment of immutable variable\n}\n```\n\nBy default, variables in Rust are immutable. To fix this error, add the keyword\n`mut` after the keyword `let` when declaring the variable. For example:\n\n```\nfn main() {\n    let mut x = 3;\n    x = 5;\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/asm-out-assign-imm.rs","byte_start":847,"byte_end":885,"line_start":31,"line_end":31,"column_start":9,"column_end":47,"is_primary":true,"text":[{"text":"        asm!(\"mov $1, $0\" : \"=r\"(x) : \"r\"(5));","highlight_start":9,"highlight_end":47}],"label":"cannot assign twice to immutable variable","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/asm-out-assign-imm.rs","byte_start":807,"byte_end":812,"line_start":28,"line_end":28,"column_start":5,"column_end":10,"is_primary":false,"text":[{"text":"    x = 1;","highlight_start":5,"highlight_end":10}],"label":"first assignment to `x`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0384]: cannot assign twice to immutable variable `x`\n  --> /checkout/src/test/ui/asm-out-assign-imm.rs:31:9\n   |\nLL |     x = 1;\n   |     ----- first assignment to `x`\n...\nLL |         asm!(\"mov $1, $0\" : \"=r\"(x) : \"r\"(5));\n   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot assign twice to immutable variable\n\n"}
[00:50:43] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[00:50:43] {"message":"For more information about this error, try `rustc --explain E0384`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0384`.\n"}
[00:50:43] ------------------------------------------
[00:50:43] 
[00:50:43] thread '[ui] ui/asm-out-assign-imm.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3096:9
[00:50:43] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:50:43] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:50:43] 
[00:50:43] ---- [ui] ui/target-feature-wrong.rs stdout ----
[00:50:43] diff of stderr:
[00:50:43] 
[00:50:43] 1 error: #[target_feature] attribute must be of the form #[target_feature(..)]
[00:50:43] +   --> $DIR/target-feature-wrong.rs:23:1
[00:50:43] 3    |
[00:50:43] 3    |
[00:50:43] 4 LL | #[target_feature = "+sse2"]
[00:50:43] 
[00:50:43] 6 
[00:50:43] 6 
[00:50:43] 7 error: the feature named `foo` is not valid for this target
[00:50:43] +   --> $DIR/target-feature-wrong.rs:25:18
[00:50:43] 9    |
[00:50:43] 9    |
[00:50:43] 10 LL | #[target_feature(enable = "foo")]
[00:50:43] 
[00:50:43] 12 
[00:50:43] 12 
[00:50:43] 13 error: #[target_feature(..)] only accepts sub-keys of `enable` currently
[00:50:43] +   --> $DIR/target-feature-wrong.rs:27:18
[00:50:43] 15    |
[00:50:43] 15    |
[00:50:43] 16 LL | #[target_feature(bar)]
[00:50:43] 
[00:50:43] 18 
[00:50:43] 18 
[00:50:43] 19 error: #[target_feature(..)] only accepts sub-keys of `enable` currently
[00:50:43] +   --> $DIR/target-feature-wrong.rs:29:18
[00:50:43] 21    |
[00:50:43] 21    |
[00:50:43] 22 LL | #[target_feature(disable = "baz")]
[00:50:43] 
[00:50:43] 24 
[00:50:43] 24 
[00:50:43] 25 error: #[target_feature(..)] can only be applied to `unsafe` function
[00:50:43] +   --> $DIR/target-feature-wrong.rs:33:1
[00:50:43] 27    |
[00:50:43] 27    |
[00:50:43] 28 LL | #[target_feature(enable = "sse2")]
[00:50:43] 
[00:50:43] 30 
[00:50:43] 31 error: attribute should be applied to a function
[00:50:43] -   --> $DIR/target-feature-wrong.rs:35:1
[00:50:43] -   --> $DIR/target-feature-wrong.rs:35:1
[00:50:43] +   --> $DIR/target-feature-wrong.rs:37:1
[00:50:43] 33    |
[00:50:43] 34 LL | #[target_feature(enable = "sse2")]
[00:50:43] 
[00:50:43] 
[00:50:43] 38    | -------------- not a function
[00:50:43] 39 
[00:50:43] 40 error: cannot use #[inline(always)] with #[target_feature]
[00:50:43] +   --> $DIR/target-feature-wrong.rs:41:1
[00:50:43] 42    |
[00:50:43] 42    |
[00:50:43] 43 LL | #[inline(always)]
[00:50:43] 
[00:50:43] 
[00:50:43] The actual stderr differed from the expected stderr.
[00:50:43] The actual stderr differed from the expected stderr.
[00:50:43] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/target-feature-wrong/target-feature-wrong.stderr
[00:50:43] To update references, rerun the tests and pass the `--bless` flag
[00:50:43] To only update this specific test, also pass `--test-args target-feature-wrong.rs`
[00:50:43] error: 1 errors occurred comparing output.
[00:50:43] status: exit code: 101
[00:50:43] status: exit code: 101
[00:50:43] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/target-feature-wrong.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/target-feature-wrong/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/target-feature-wrong/auxiliary" "-A" "unused"
[00:50:43] ------------------------------------------
[00:50:43] 
[00:50:43] ------------------------------------------
[00:50:43] stderr:
[00:50:43] stderr:
[00:50:43] ------------------------------------------
[00:50:43] {"message":"#[target_feature] attribute must be of the form #[target_feature(..)]","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/target-feature-wrong.rs","byte_start":648,"byte_end":675,"line_start":23,"line_end":23,"column_start":1,"column_end":28,"is_primary":true,"text":[{"text":"#[target_feature = \"+sse2\"]","highlight_start":1,"highlight_end":28}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: #[target_feature] attribute must be of the form #[target_feature(..)]\n  --> /checkout/src/test/ui/target-feature-wrong.rs:23:1\n   |\nLL | #[target_feature = \"+sse2\"]\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\n"}
[00:50:43] {"message":"the feature named `foo` is not valid for this target","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/target-feature-wrong.rs","byte_start":725,"byte_end":739,"line_start":25,"line_end":25,"column_start":18,"column_end":32,"is_primary":true,"text":[{"text":"#[target_feature(enable = \"foo\")]","highlight_start":18,"highlight_end":32}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: the feature named `foo` is not valid for this target\n  --> /checkout/src/test/ui/target-feature-wrong.rs:25:18\n   |\nLL | #[target_feature(enable = \"foo\")]\n   |                  ^^^^^^^^^^^^^^\n\n"}
[00:50:43] {"message":"#[target_feature(..)] only accepts sub-keys of `enable` currently","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/target-feature-wrong.rs","byte_start":797,"byte_end":800,"line_start":27,"line_end":27,"column_start":18,"column_end":21,"is_primary":true,"text":[{"text":"#[target_feature(bar)]","highlight_start":18,"highlight_end":21}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: #[target_feature(..)] only accepts sub-keys of `enable` currently\n  --> /checkout/src/test/ui/target-feature-wrong.rs:27:18\n   |\nLL | #[target_feature(bar)]\n   |                  ^^^\n\n"}
[00:50:43] {"message":"#[target_feature(..)] only accepts sub-keys of `enable` currently","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/target-feature-wrong.rs","byte_start":854,"byte_end":869,"line_start":29,"line_end":29,"column_start":18,"column_end":33,"is_primary":true,"text":[{"text":"#[target_feature(disable = \"baz\")]","highlight_start":18,"highlight_end":33}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: #[target_feature(..)] only accepts sub-keys of `enable` currently\n  --> /checkout/src/test/ui/target-feature-wrong.rs:29:18\n   |\nLL | #[target_feature(disable = \"baz\")]\n   |                  ^^^^^^^^^^^^^^^\n\n"}
[00:50:43] {"message":"#[target_feature(..)] can only be applied to `unsafe` function","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/target-feature-wrong.rs","byte_start":926,"byte_end":960,"line_start":33,"line_end":33,"column_start":1,"column_end":35,"is_primary":true,"text":[{"text":"#[target_feature(enable = \"sse2\")]","highlight_start":1,"highlight_end":35}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: #[target_feature(..)] can only be applied to `unsafe` function\n  --> /checkout/src/test/ui/target-feature-wrong.rs:33:1\n   |\nLL | #[target_feature(enable = \"sse2\")]\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\n"}
[00:50:43] {"message":"attribute should be applied to a function","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/target-feature-wrong.rs","byte_start":1106,"byte_end":1120,"line_start":39,"line_end":39,"column_start":1,"column_end":15,"is_primary":false,"text":[{"text":"mod another {}","highlight_start":1,"highlight_end":15}],"label":"not a function","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/target-feature-wrong.rs","byte_start":1027,"byte_end":1061,"line_start":37,"line_end":37,"column_start":1,"column_end":35,"is_primary":true,"text":[{"text":"#[target_feature(enable = \"sse2\")]","highlight_start":1,"highlight_end":35}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: attribute should be applied to a function\n  --> /checkout/src/test/ui/target-feature-wrong.rs:37:1\n   |\nLL | #[target_feature(enable = \"sse2\")]\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nLL | //~^ ERROR: should be applied to a function\nLL | mod another {}\n   | -------------- not a function\n\n"}
[00:50:43] {"message":"cannot use #[inline(always)] with #[target_feature]","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/target-feature-wrong.rs","byte_start":1122,"byte_end":1139,"line_start":41,"line_end":41,"column_start":1,"column_end":18,"is_primary":true,"text":[{"text":"#[inline(always)]","highlight_start":1,"highlight_end":18}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: cannot use #[inline(always)] with #[target_feature]\n  --> /checkout/src/test/ui/target-feature-wrong.rs:41:1\n   |\nLL | #[inline(always)]\n   | ^^^^^^^^^^^^^^^^^\n\n"}
[00:50:43] {"message":"aborting due to 7 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 7 previous errors\n\n"}
[00:50:43] ------------------------------------------
[00:50:43] 
[00:50:43] thread '[ui] ui/target-feature-wrong.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3096:9
[00:50:43] 
---
[00:50:43] 
[00:50:43] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:498:22
[00:50:43] 
[00:50:43] 
[00:50:43] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:50:43] 
[00:50:43] 
[00:50:43] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:50:43] Build completed unsuccessfully in 0:02:53
[00:50:43] Build completed unsuccessfully in 0:02:53
[00:50:43] make: *** [check] Error 1
[00:50:43] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:16a32268
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

glaubitz · 2018-06-04T12:27:33Z

Hmm, I don't think that my changes should have any effect on the CI tests.

Can someone retry this?

glaubitz · 2018-06-05T11:42:21Z

Testsuite passes now. Anyone can pick this?

@shepmaster Could you pick this? I can then also take care of #51237.

shepmaster · 2018-06-05T13:30:28Z

See, I told you that the error locations changed ;-)

@bors r+ rollup

bors · 2018-06-05T13:30:29Z

📌 Commit 6902409 has been approved by shepmaster

glaubitz · 2018-06-05T13:34:32Z

Jaja :P. It took me a while to understand what the problem was. Thanks for the review!

test: Ignore some problematic tests on sparc and sparc64 This updates the list of tests which can be safely ignored on sparc and sparc64.

Rollup of 7 pull requests Successful merges: - #50852 (Add doc comment to hiding portions of code example) - #51183 (Update rustdoc book to suggest using Termination trait instead of hidden ‘foo’ function) - #51255 (Fix confusing error message for sub_instant) - #51256 (Fix crate-name option in rustdoc) - #51308 (Check array indices in constant propagation) - #51343 (test: Ignore some problematic tests on sparc and sparc64) - #51358 (Tests that #39963 is fixed on MIR borrowck) Failed merges:

rust-highfive assigned aturon Jun 4, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2018

glaubitz mentioned this pull request Jun 4, 2018

1.26.0 - ppc64 little+big endian compile-fail/asm-* test failures #50989

Closed

glaubitz force-pushed the sparc64-tests branch from a98389a to 211db7a Compare June 4, 2018 21:59

test: Ignore some problematic tests on sparc and sparc64

6902409

glaubitz force-pushed the sparc64-tests branch from 211db7a to 6902409 Compare June 4, 2018 21:59

glaubitz mentioned this pull request Jun 5, 2018

Ignore test files on powerpc64* that's already ignored on powerpc #51237

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2018

Mark-Simulacrum mentioned this pull request Jun 5, 2018

Rollup of 7 pull requests #51369

Merged

bors merged commit 6902409 into rust-lang:master Jun 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Ignore some problematic tests on sparc and sparc64 #51343

test: Ignore some problematic tests on sparc and sparc64 #51343

glaubitz commented Jun 4, 2018

rust-highfive commented Jun 4, 2018

rust-highfive commented Jun 4, 2018

glaubitz commented Jun 4, 2018

glaubitz commented Jun 5, 2018 •

edited

shepmaster commented Jun 5, 2018

bors commented Jun 5, 2018

glaubitz commented Jun 5, 2018

test: Ignore some problematic tests on sparc and sparc64 #51343

test: Ignore some problematic tests on sparc and sparc64 #51343

Conversation

glaubitz commented Jun 4, 2018

rust-highfive commented Jun 4, 2018

rust-highfive commented Jun 4, 2018

glaubitz commented Jun 4, 2018

glaubitz commented Jun 5, 2018 • edited

shepmaster commented Jun 5, 2018

bors commented Jun 5, 2018

glaubitz commented Jun 5, 2018

glaubitz commented Jun 5, 2018 •

edited