Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-pub some items whose visibilities were recently reduced. #51724

Merged
merged 1 commit into from
Jun 23, 2018
Merged

Re-pub some items whose visibilities were recently reduced. #51724

merged 1 commit into from
Jun 23, 2018

Conversation

tikue
Copy link
Contributor

@tikue tikue commented Jun 22, 2018

Reasons described in the most recent comments of #51265.

tarpc can't move off of plugins until proc macros can be reexported from other crates.

Fixes google/tarpc#191

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2018
@tikue tikue changed the title Re-reexport some items that were recently made crate-private. Re-publicize some items whose visibilities were recently reduced. Jun 22, 2018
@tikue tikue changed the title Re-publicize some items whose visibilities were recently reduced. Re-pub some items whose visibilities were recently reduced. Jun 22, 2018
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 22, 2018

📌 Commit 0c33e0a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2018
@bors
Copy link
Contributor

bors commented Jun 23, 2018

⌛ Testing commit 0c33e0a with merge 2db44b6...

bors added a commit that referenced this pull request Jun 23, 2018
@bors
Auto merge of #51724 - tikue:master, r=Mark-Simulacrum
2db44b6 
Re-pub some items whose visibilities were recently reduced.

Reasons described in the most recent comments of #51265.

tarpc can't move off of plugins until proc macros can be reexported from other crates.

Fixes google/tarpc#191
@bors
Copy link
Contributor

bors commented Jun 23, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 2db44b6 to master...

@bors bors merged commit 0c33e0a into rust-lang:master Jun 23, 2018
@eddyb
Copy link
Member

eddyb commented Jun 24, 2018

There should probably be an issue for going back to private to force migration off of plugins.
We should also start marking the plugin APIs as deprecated.

@SimonSapin SimonSapin mentioned this pull request Jun 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tikue @rust-highfive @Mark-Simulacrum @bors @eddyb @michaelwoerister