-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not attempt to recompile codegen backend(s) with --keep-stage #52360
Do not attempt to recompile codegen backend(s) with --keep-stage #52360
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Previously we'd attempt to recompile them and that would fail since we've essentially not built the entire compiler yet, or we're faking that fact. This commit should make us ignore the codegen backend build as well. Unlike the other compile steps, there is no CodegenBackendLink step that we run here, because that is done later as a part of assembling the final compiler and as an explicit function call.
4755a72
to
a569c24
Compare
Hi Mark! This does not solve things for me, though it does change the error message. This is the full message:
The important part being:
Before running this I did a full test compile once by executing the same command but without |
Keeping stage 1 and running in stage 2 gives a slightly different error:
|
It didn't fully work for me either. I first did Then I changed something in
|
The best way to build a stage 2 rustc is now probably ./x.py build --stage 2 src/rustc # once ./x.py build --stage 2 --keep-stage 1 src/rustc
@bors: r+ |
📌 Commit 8eddaba has been approved by |
…, r=alexcrichton Do not attempt to recompile codegen backend(s) with --keep-stage Previously we'd attempt to recompile them and that would fail since we've essentially not built the entire compiler yet, or we're faking that fact. This commit should make us ignore the codegen backend build as well. Unlike the other compile steps, there is no CodegenBackendLink step that we run here, because that is done later as a part of assembling the final compiler and as an explicit function call. r? @alexcrichton I think this may fix or at least assist with #52174. cc @RalfJung @tinco -- if you can test this patch locally that'd be amazing; I don't want to recompile for the next couple hours to test it locally. I don't think it can make the situation worse, and in fact, if I've interpreted the cause of the failure correctly then this will fix your problem.
☀️ Test successful - status-appveyor, status-travis |
Previously we'd attempt to recompile them and that would fail since
we've essentially not built the entire compiler yet, or we're faking
that fact. This commit should make us ignore the codegen backend build
as well.
Unlike the other compile steps, there is no CodegenBackendLink step that
we run here, because that is done later as a part of assembling the
final compiler and as an explicit function call.
r? @alexcrichton
I think this may fix or at least assist with #52174.
cc @RalfJung @tinco -- if you can test this patch locally that'd be
amazing; I don't want to recompile for the next couple hours to test it
locally. I don't think it can make the situation worse, and in fact, if
I've interpreted the cause of the failure correctly then this will fix
your problem.