Documented impl From on line 367 of libserialize/json.rs #52946
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Hmmm. So the name on the |
|
Triage: r? @frewsxcv |
|
Ping from triage @frewsxcv / @rust-lang/docs: This PR requires your review. |
src/libserialize/json.rs
Outdated
| @@ -365,6 +365,9 @@ impl std::error::Error for EncoderError { | |||
| } | |||
|
|
|||
| impl From<fmt::Error> for EncoderError { | |||
| /// Converts a `fmt::Error` into `EncoderError` | |||
There was a problem hiding this comment.
Please change to "Converts a [`fmt::Error`] into `EncoderError`."
|
My bad. It should be fixed now. |
|
Thanks! @bors: r+ rollup |
|
📌 Commit 352b2e7 has been approved by |
bors
added
S-waiting-on-bors
…omez Documented impl From on line 367 of libserialize/json.rs This is for the impl From mentioned in rust-lang#51430 assigned to @skade . Hopefully I didn't miss anything/get anything wrong. I looked over another PR for another part of this same issue to see what the proper formatting was, etc. Thanks!
Rollup of 10 pull requests Successful merges: - #52946 (Documented impl From on line 367 of libserialize/json.rs) - #53234 (Remove Travis shutdown debug scripts, and remove CI-specific DNS settings) - #53313 (Two small improvements) - #53360 (Addressed #51602) - #53364 (Warn if the user tries to use GATs) - #53373 (Tweak unclosed delimiter parser error) - #53377 (std: Use target_pointer_width for BACKTRACE_ELF_SIZE) - #53395 (Use #[non_exhaustive] on internal enums) - #53399 (Tidy: ignore non-Markdown files when linting for the Unstable Book) - #53412 (syntax_ext: remove leftover span_err_if_not_stage0 macro.)
This is for the impl From mentioned in #51430 assigned to @skade .
Hopefully I didn't miss anything/get anything wrong. I looked over another PR for another part of this same issue to see what the proper formatting was, etc.
Thanks!